[Bug 886439] Re: upgrade to upstart 1.3-0ubuntu11 causes unclean shutdown
Launchpad Bug Tracker
886439 at bugs.launchpad.net
Mon Jan 2 09:08:14 UTC 2012
This bug was fixed in the package sysvinit - 2.88dsf-13.10ubuntu4.1
---------------
sysvinit (2.88dsf-13.10ubuntu4.1) oneiric-proposed; urgency=low
* d/src/initscripts/etc/init.d/sendsigs: wait up to 300 extra
seconds for upstart jobs that have been killed. They will be sent
SIGKILL by upstart when their 'kill timeout' has been reached, so
we should trust the job's author to give the service a reasonable
amount of time to shut down. (LP: #688541)
* also omit pids of stop/killed upstart jobs since we know they've
been killed already.
* d/src/initscripts/etc/init.d/umountroot: Check for init.upgraded
file in /var/run before clearing out /var/run. (LP: #886439)
-- Clint Byrum <clint at ubuntu.com> Mon, 12 Dec 2011 16:08:10 -0800
** Changed in: sysvinit (Ubuntu Oneiric)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to upstart in Ubuntu.
https://bugs.launchpad.net/bugs/886439
Title:
upgrade to upstart 1.3-0ubuntu11 causes unclean shutdown
Status in “sysvinit” package in Ubuntu:
Fix Released
Status in “upstart” package in Ubuntu:
Invalid
Status in “sysvinit” source package in Oneiric:
Fix Released
Status in “upstart” source package in Oneiric:
Invalid
Bug description:
== SRU JUSTIFICATION ==
IMPACT: its possible, though not all that likely, that files and
metadata will be out of sync when systems are shutdown or rebooted
after upgrading upstart or any of the libraries it depends on (namely,
libc6). Therefore the potential impact is data corruption.
TEST CASE:
Steps to reproduce:
1. Start an Ubuntu 11.10 Oneiric instance on EC2.
Example: ec2run ami-bbf539d2 -t t1.micro -k key
2. Save sudo lsof for reference.
3. apt-cache show upstart
The stock version of upstart installed is 1.3-0ubuntu10.
4. sudo apt-get update; sudo apt-get install upstart
upstart is upgraded to 1.3-0ubuntu11
5. Verify that /var/run/init.upgraded is in fact touched by the install.
6. Save sudo lsof for reference.
7. sudo shutdown -h now
The console displays while unmounting:
mount: / is busy
This error will not show when the bug is fixed.
DEV FIX: The problem is that /var/run is cleared out for the
transition to /run before the 'init.upgraded' flag file is checked
for. The order of operations is changed.
REGRESSION POTENTIAL: The code path that is changed is very straight
forward and tight, just swapping the order of two basic sets of
operations. I would consider this to have a low regression potential
then.
=====
This causes filesystem recovery errors on next boot.
The post-upgrade lsof is attached.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/sysvinit/+bug/886439/+subscriptions
More information about the foundations-bugs
mailing list