[Bug 913991] [NEW] dbus package installs debug dbus-daemon binary

[Jason Conti]

Public bug reported:

The dbus-daemon binary installed to /bin from the dbus package appears to be the debug version
with all of the DBUS_BUILD_TESTS sections enabled. (Probably likewise for the other binaries, but
I only noticed dbus-daemon because of https://bugs.freedesktop.org/show_bug.cgi?id=43303 )

Looking at, for instance, https://launchpadlibrarian.net/89440977
/buildlog_ubuntu-precise-amd64.dbus_1.4.16-1ubuntu3_BUILDING.txt.gz it
first installs the normal binary into debian/tmp//bin:

Making install in bus
make[3]: Entering directory `/build/buildd/dbus-1.4.16/build/bus'
make[4]: Entering directory `/build/buildd/dbus-1.4.16/build/bus'
test -z "//bin" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp//bin"
test -z "//bin" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp//bin"
test -z "/usr/lib/dbus-1.0" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp/usr/lib/dbus-1.0"
  /bin/bash ../libtool   --mode=install /usr/bin/install -c dbus-daemon '/build/buildd/dbus-1.4.16/debian/tmp//bin'
  /bin/bash ../libtool   --mode=install /usr/bin/install -c dbus-daemon-launch-helper '/build/buildd/dbus-1.4.16/debian/tmp/usr/lib/dbus-1.0'
libtool: install: /usr/bin/install -c dbus-daemon /build/buildd/dbus-1.4.16/debian/tmp//bin/dbus-daemon

and then later overwrites it with the debug binary:

Making install-exec in bus
make[3]: Entering directory `/build/buildd/dbus-1.4.16/build-debug/bus'
test -z "//bin" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp//bin"
test -z "//bin" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp//bin"
  /bin/bash ../libtool   --mode=install /usr/bin/install -c dbus-daemon '/build/buildd/dbus-1.4.16/debian/tmp//bin'
libtool: install: /usr/bin/install -c dbus-daemon /build/buildd/dbus-1.4.16/debian/tmp//bin/dbus-daemon
test -z "/usr/lib/x86_64-linux-gnu/dbus-1.0/debug-build/lib/dbus-1.0" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp/usr/lib/x86_64-linux-gnu/dbus-1.0/debug-build/lib/dbus-1.0"
  /bin/bash ../libtool   --mode=install /usr/bin/install -c dbus-daemon-launch-helper '/build/buildd/dbus-1.4.16/debian/tmp/usr/lib/x86_64-linux-gnu/dbus-1.0/debug-build/lib/dbus-1.0'

I think this can be fixed by moving --exec-prefix=/ in debian/rules from the common_configure_flags to the
configure flags for the normal build so it doesn't override --prefix=/usr/lib/$(DEB_HOST_MULTIARCH)/dbus-1.0/debug-build
from the debug build.

Rebuilding with this change (although I also added the binary install target to debian/dbus-1-dbg.install) and the
size of the dbus-daemon binary drops from about 800K before to about 400K.

** Affects: dbus (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to dbus in Ubuntu.
https://bugs.launchpad.net/bugs/913991

Title:
  dbus package installs debug dbus-daemon binary

Status in “dbus” package in Ubuntu:
  New

Bug description:
  The dbus-daemon binary installed to /bin from the dbus package appears to be the debug version
  with all of the DBUS_BUILD_TESTS sections enabled. (Probably likewise for the other binaries, but
  I only noticed dbus-daemon because of https://bugs.freedesktop.org/show_bug.cgi?id=43303 )

  Looking at, for instance, https://launchpadlibrarian.net/89440977
  /buildlog_ubuntu-precise-amd64.dbus_1.4.16-1ubuntu3_BUILDING.txt.gz it
  first installs the normal binary into debian/tmp//bin:

  Making install in bus
  make[3]: Entering directory `/build/buildd/dbus-1.4.16/build/bus'
  make[4]: Entering directory `/build/buildd/dbus-1.4.16/build/bus'
  test -z "//bin" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp//bin"
  test -z "//bin" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp//bin"
  test -z "/usr/lib/dbus-1.0" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp/usr/lib/dbus-1.0"
    /bin/bash ../libtool   --mode=install /usr/bin/install -c dbus-daemon '/build/buildd/dbus-1.4.16/debian/tmp//bin'
    /bin/bash ../libtool   --mode=install /usr/bin/install -c dbus-daemon-launch-helper '/build/buildd/dbus-1.4.16/debian/tmp/usr/lib/dbus-1.0'
  libtool: install: /usr/bin/install -c dbus-daemon /build/buildd/dbus-1.4.16/debian/tmp//bin/dbus-daemon

  and then later overwrites it with the debug binary:

  Making install-exec in bus
  make[3]: Entering directory `/build/buildd/dbus-1.4.16/build-debug/bus'
  test -z "//bin" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp//bin"
  test -z "//bin" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp//bin"
    /bin/bash ../libtool   --mode=install /usr/bin/install -c dbus-daemon '/build/buildd/dbus-1.4.16/debian/tmp//bin'
  libtool: install: /usr/bin/install -c dbus-daemon /build/buildd/dbus-1.4.16/debian/tmp//bin/dbus-daemon
  test -z "/usr/lib/x86_64-linux-gnu/dbus-1.0/debug-build/lib/dbus-1.0" || /bin/mkdir -p "/build/buildd/dbus-1.4.16/debian/tmp/usr/lib/x86_64-linux-gnu/dbus-1.0/debug-build/lib/dbus-1.0"
    /bin/bash ../libtool   --mode=install /usr/bin/install -c dbus-daemon-launch-helper '/build/buildd/dbus-1.4.16/debian/tmp/usr/lib/x86_64-linux-gnu/dbus-1.0/debug-build/lib/dbus-1.0'

  I think this can be fixed by moving --exec-prefix=/ in debian/rules from the common_configure_flags to the
  configure flags for the normal build so it doesn't override --prefix=/usr/lib/$(DEB_HOST_MULTIARCH)/dbus-1.0/debug-build
  from the debug build.

  Rebuilding with this change (although I also added the binary install target to debian/dbus-1-dbg.install) and the
  size of the dbus-daemon binary drops from about 800K before to about 400K.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dbus/+bug/913991/+subscriptions