[Bug 800561]

[Martin Pitt]

(In reply to comment #10)
> Ok, some comments:
> 1. You did not change VERSION_INFO in configure.ac. I guess it was just
> overlooked, right? The API is changed, even though in the compatible way.

Right, sorry, I overlooked it. I should be bumped for the patches 2 to
5.

> 2. The xkl_config_item_new_with_data - I do not have strong objection, but why
> are just plain setters/getters not sufficient?

They would be sufficient. If you prefer individual setters, I can change
the patches accordingly.

> 3. Why is that in Makefile.am?
> -xklavier_headers = xklavier.h xkl_config_registry.h xkl_engine.h \
> -    xkl_config_rec.h xkl_config_item.h xkl_engine_marshal.h
> +xklavier_headers = xkl_engine.h xkl_config_item.h xkl_config_registry.h \
> +    xkl_config_rec.h xkl_engine_marshal.h xklavier.h

With the original order, g-ir-scanner failed on some unknown symbols. It
seems to have some left-to-right ordering. That's not very scientific, I
know, I'm not a guru for the g-i implementation.

> 4. set_log_appender is mostly for debugging, so for now let's ignore
it

Agreed.

> 5. I will check around get_current_state. Perhaps making it const would be
> affordable...

I'm not sure that const will help, as even with const the interpreter
might still need to copy the value. Boxing the struct (i. e. providing a
proper constructor and _copy() method) should help. Again, I wasn't
terribly concerned about this particular method; once you are happy with
the current patches and they can land, we can do the finishing touches.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/800561

Title:
  No way to add other keymap than english on Live CD

Status in libxklavier - XKB foundation libary:
  Fix Released
Status in “libxklavier” package in Ubuntu:
  In Progress
Status in “ubiquity” package in Ubuntu:
  Triaged
Status in “ubiquity” source package in Oneiric:
  Won't Fix
Status in “libxklavier” source package in Precise:
  In Progress
Status in “ubiquity” source package in Precise:
  Triaged

Bug description:
  TEST CASE:
  1. Boot a live cd
  2. Select "Try Ubuntu" and start the live session
  3. Click on the Keyboard indicator
    -> Verify that there is no French, Spanish or German keymap on the list (nothing else than US keymaps actually)
  4. At the bottom of the list click on "Keyboard Preferences".
    -> It opens the "Region and Language" configuration panel
  5. Click on the "Layout" tab to add a new layout

  Result:
  The list only contains english/us layouts
  The "+" button below the list is disabled and no new layout can be added

  WORKAROUND
   * On the "Layouts" tab click on "Reset to defaults"
   * All the existing layouts are removed and the "+" button is enabled, the user can then add a new layout.

  ProblemType: Bug
  DistroRelease: Ubuntu 11.10
  Package: gnome-control-center 1:3.0.2-1ubuntu4
  ProcVersionSignature: Ubuntu 3.0-1.2-generic 3.0.0-rc3
  Uname: Linux 3.0-1-generic x86_64
  Architecture: amd64
  Date: Wed Jun 22 08:29:28 2011
  LiveMediaBuild: Ubuntu 11.10 "Oneiric Ocelot" - Alpha amd64 (20110621)
  ProcEnviron:
   PATH=(custom, no user)
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: gnome-control-center
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/libxklavier/+bug/800561/+subscriptions