[Bug 1000298] Re: /etc/motd.tail is silently removed on upgrade of initscripts

[Ubuntu Foundation's Bug Bot]

The attachment "save-etc-motd-tail.patch" of this bug report has been
identified as being a patch.  The ubuntu-reviewers team has been
subscribed to the bug report so that they can review the patch.  In the
event that this is in fact not a patch you can resolve this situation by
removing the tag 'patch' from the bug report and editing the attachment
so that it is not flagged as a patch.  Additionally, if you are member
of the ubuntu-reviewers team please also unsubscribe the team from this
bug report.

[This is an automated message performed by a Launchpad user owned by
Brian Murray.  Please contact him regarding any issues with the action
taken in this bug report.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to sysvinit in Ubuntu.
https://bugs.launchpad.net/bugs/1000298

Title:
  /etc/motd.tail is silently removed on upgrade of initscripts

Status in “sysvinit” package in Ubuntu:
  New

Bug description:
  /etc/motd.tail is always removed on upgrade of initscripts. I
  encountered this problem on upgrading my Ubuntu server from 10.04 to
  12.04.

  This problem is caused by misuse of fgrep in initscripts.postinst:

   ...
          help_text=$(/etc/update-motd.d/10-help-text 2>/dev/null || true)
          if [ -n "$help_text" ] && fgrep -q "$help_text" /etc/motd.tail
          then
                  rm -f /etc/motd.tail
   ...

  /etc/update-motd.d/10-help-text *outputs a single newline* before the
  line containing "Documents: https://help.ubuntu.com/". On the other
  hands, man grep reads:

         -F, --fixed-strings
                Interpret PATTERN as a list of fixed strings, separated by newlines, any of which is to be matched.  (-F is specified by POSIX.)

  Then this fgrep call always succeeds and /etc/motd.tail is removed.

  I attached a patch to solve this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/sysvinit/+bug/1000298/+subscriptions