[Bug 1058356] Re: fails to install when kernel does not provide block_suspend capability

[Jamie Strandboge]

I can reproduce the failure of cups to start, but have not been able to
reproduce upgrading from 12.04 to 12.10.

** Description changed:

  [IMPACT]
-  * Users upgrading from 12.04 LTS to 12.10 will encounter upgrade errors because
+  * Some users upgrading from 12.04 LTS to 12.10 have encountered upgrade errors because
     apparmor_parser fails to load new policy on an old kernel. Specifically, the
     block_suspend capability is new in the 12.10 kernel and does not exist in the
     12.04 LTS kernel. On upgrade, the cups upstart job calls
     /lib/init/apparmor-profile-load from upstart, which in turn calls apparmor_parser.
-    apparmor_parser will exit with error on upgrades causing the upstart job to fail
-    no restart, which is performed during the upgrade.
+    apparmor_parser can exit with error on upgrades causing the upstart job to fail.
  
  [TESTCASE]
-  * One can either
-    - perform an upgrade from 12.04 to 12.10, or
+  * Regular upgrades using do-release-upgrade or update-manager don't seem to be affected,
+    so it is best to:
     - obtain the apparmor profile from the 12.10 cups package[1], copy it to
-      /etc/apparmor.d/usr.sbin.cupsd and then perform 'sudo restart cups'. If the
-      bug is not fixed, you will see 'restart: Job failed to restart'. If it is
-      fixed, you will see 'cups start/running, process ####' (note, if cups is not
-      already running you will need to do 'sudo start cups' instead of 'restart').
+      /etc/apparmor.d/usr.sbin.cupsd and then perform 'sudo stop cups ; sudo start cups'. 
+      If the bug is not fixed, you will see 'start: Job failed to start'. If it is
+      fixed, you will see 'cups start/running, process ####'.
  
  [1]http://bazaar.launchpad.net/~ubuntu-
  branches/ubuntu/quantal/cups/quantal/view/head:/debian/local/apparmor-
  profile
  
  [Regression Potential]
   * The regression potential is extremely low. The only change is adding '|| exit 0' to a
     shell script.
  
  [Other Info]
   * This has been discussed with the security team, the release team and foundations and
     we all agree this is the best fix at this time.
-  * On upgrades, upstart is unpacked very early (much earlier than cups), so the new
-    /lib/init/apparmor-profile-load should be in place when cups is restarted
+  * On upgrades, upstart is unpacked very early (much earlier than cups), so the new
+    /lib/init/apparmor-profile-load should be in place when cups is restarted
  
  Previous report:
  On our Jenkins builds we're getting a failure to install the cups package.  This seems to be because the apparmor profile looks for suspend capability but the virtualized builders do not have it.  Here seems to be the relevant log:
  
  AppArmor parser error for /etc/apparmor.d/usr.sbin.cupsd in /etc/apparmor.d/usr.sbin.cupsd at line 24: Invalid capability block_suspend.
  start: Job failed to start
  invoke-rc.d: initscript cups, action "start" failed.
  dpkg: error processing cups (--configure):
   subprocess installed post-installation script returned error exit status 1
  Errors were encountered while processing:
   cups
  E: Sub-process /usr/bin/dpkg returned an error code (1)
  
  Full log: https://jenkins.qa.ubuntu.com/job/indicator-session-
  ci/label=quantal/16/console

** Changed in: upstart (Ubuntu Quantal)
   Importance: High => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to upstart in Ubuntu.
https://bugs.launchpad.net/bugs/1058356

Title:
  fails to install when kernel does not provide block_suspend capability

Status in “upstart” package in Ubuntu:
  Fix Committed
Status in “upstart” source package in Quantal:
  Fix Committed

Bug description:
  [IMPACT]
   * Some users upgrading from 12.04 LTS to 12.10 have encountered upgrade errors because
     apparmor_parser fails to load new policy on an old kernel. Specifically, the
     block_suspend capability is new in the 12.10 kernel and does not exist in the
     12.04 LTS kernel. On upgrade, the cups upstart job calls
     /lib/init/apparmor-profile-load from upstart, which in turn calls apparmor_parser.
     apparmor_parser can exit with error on upgrades causing the upstart job to fail.

  [TESTCASE]
   * Regular upgrades using do-release-upgrade or update-manager don't seem to be affected,
     so it is best to:
     - obtain the apparmor profile from the 12.10 cups package[1], copy it to
       /etc/apparmor.d/usr.sbin.cupsd and then perform 'sudo stop cups ; sudo start cups'. 
       If the bug is not fixed, you will see 'start: Job failed to start'. If it is
       fixed, you will see 'cups start/running, process ####'.

  [1]http://bazaar.launchpad.net/~ubuntu-
  branches/ubuntu/quantal/cups/quantal/view/head:/debian/local/apparmor-
  profile

  [Regression Potential]
   * The regression potential is extremely low. The only change is adding '|| exit 0' to a
     shell script.

  [Other Info]
   * This has been discussed with the security team, the release team and foundations and
     we all agree this is the best fix at this time.
   * On upgrades, upstart is unpacked very early (much earlier than cups), so the new
     /lib/init/apparmor-profile-load should be in place when cups is restarted

  Previous report:
  On our Jenkins builds we're getting a failure to install the cups package.  This seems to be because the apparmor profile looks for suspend capability but the virtualized builders do not have it.  Here seems to be the relevant log:

  AppArmor parser error for /etc/apparmor.d/usr.sbin.cupsd in /etc/apparmor.d/usr.sbin.cupsd at line 24: Invalid capability block_suspend.
  start: Job failed to start
  invoke-rc.d: initscript cups, action "start" failed.
  dpkg: error processing cups (--configure):
   subprocess installed post-installation script returned error exit status 1
  Errors were encountered while processing:
   cups
  E: Sub-process /usr/bin/dpkg returned an error code (1)

  Full log: https://jenkins.qa.ubuntu.com/job/indicator-session-
  ci/label=quantal/16/console

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/upstart/+bug/1058356/+subscriptions