[Bug 1028388] Re: software-properties-gtk crashed with KeyError in show_drivers(): 'model'

[Mathieu Trudel-Lapierre]

This would be my proposed fix so far:

--- softwareproperties/gtk/SoftwarePropertiesGtk.py	2012-08-28 13:29:24 +0000
+++ softwareproperties/gtk/SoftwarePropertiesGtk.py	2012-09-10 16:10:18 +0000
@@ -1265,7 +1265,7 @@
       device_detail = Gtk.Box(spacing=6, orientation=Gtk.Orientation.VERTICAL)
       device_box.pack_start(device_detail, True, True, 0)
 
-      widget = Gtk.Label("{}: {}".format(self.devices[device]['vendor'], self.devices[device]['model']))
+      widget = Gtk.Label("{}: {}".format(self.devices[device].get('vendor', _('Unknown')), self.devices[device].get('model', _('Unknown'))))
       widget.set_halign(Gtk.Align.START)
       device_detail.pack_start(widget, True, False, 0)
       widget = Gtk.Label("<small>{}</small>".format(overall_status))


Replacing the missing strings when the dictionary keys are unavailable with "Unknown", which introduces a new string and thus should need an UI freeze exception.

** Summary changed:

- software-properties-gtk crashed with KeyError in show_drivers(): 'model'
+ [UIFe] software-properties-gtk crashed with KeyError in show_drivers(): 'model'

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/1028388

Title:
  [UIFe] software-properties-gtk crashed with KeyError in
  show_drivers(): 'model'

Status in “software-properties” package in Ubuntu:
  In Progress
Status in “software-properties” source package in Quantal:
  In Progress

Bug description:
  Software update crashed duering attempt to reach settings for software
  update

  ProblemType: Crash
  DistroRelease: Ubuntu 12.10
  Package: software-properties-gtk 0.91
  ProcVersionSignature: Ubuntu 3.5.0-6.6-generic 3.5.0
  Uname: Linux 3.5.0-6-generic x86_64
  NonfreeKernelModules: nvidia
  ApportVersion: 2.4-0ubuntu5
  Architecture: amd64
  CrashCounter: 1
  Date: Tue Jul 24 13:13:53 2012
  ExecutablePath: /usr/bin/software-properties-gtk
  InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Release amd64 (20120425)
  InterpreterPath: /usr/bin/python3.2mu
  PackageArchitecture: all
  ProcCmdline: /usr/bin/python3.2 /usr/bin/software-properties-gtk --open-tab 2
  ProcEnviron:
   PATH=(custom, no user)
   LANG=da_DK.UTF-8
   SHELL=/bin/bash
  PythonArgs: ['/usr/bin/software-properties-gtk', '--open-tab', '2']
  SourcePackage: software-properties
  Title: software-properties-gtk crashed with KeyError in show_drivers(): 'model'
  UpgradeStatus: No upgrade log present (probably fresh install)
  UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo vboxusers

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1028388/+subscriptions