[Bug 1056707] Re: "Unsafe swap space detected" dialog displayed too late if swap is created after an encrypted partition and makes manual partitioner unusable

[Colin Watson]

You'll need to check if it works, of course, but my recommendation would
be to move the unsafe_swap script in partman-crypto from commit.d to
check.d.  That's where most checks of this kind belong, but the check.d
facility is newer than much of the rest of partman so it isn't used
quite everywhere it should be.

It's possible that you may have to rearrange unsafe_swap a little bit to
deal with checking the disk layout that's about to be committed rather
than whatever's currently on disk.  I haven't read through it in enough
detail to be sure about this.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1056707

Title:
  "Unsafe swap space detected" dialog displayed too late if swap is
  created after an encrypted partition and makes manual partitioner
  unusable

Status in “ubiquity” package in Ubuntu:
  Triaged
Status in “ubiquity” source package in Quantal:
  Triaged

Bug description:
  Quantal Desktop 20120926

  In the manual partitioner, if the user creates the swap space after
  the encrypted space then installation starts and the "Unsafe swap
  space detected" dialog is shown during the timezone step. When the
  dialog is dismissed, it brings the user back to the guided partitioner
  not the manual partitioner.

  Then, if I use the manual partitioner again, it is unusable, all the
  actions are greyed, only 'Change' is enabled but does nothing

  In the guided partioner, If I select 'Erase everything' then
  installation stops on error with a dialog titled 'ERROR!!!'
  "'/dev/sdaX' device or resource busy."

  The dialog should be displayed when the user creates the swap space
  and the manual partitioner should allow to fix the mistake.

  TEST CASE:
  1. Start Ubiquity and go to the manual partitioner
  2. Create a new partition table
  3. Add a partition of type "physical volume for encryption" and do not allocate all disk space, enter a passphrase and press 'ok'
  4. Select the newly created partition and mount it on '/'
  5. Select the free space and create a partition of type 'ext4', mounted on '/boot' and keep free space for a swap partition.
  6. Select the free space and create a partition of type 'swap space'
  7. Press 'Install Now'

  ACTUAL RESULT:
  Installation continues, proceeds to the timezone step and the stops with a dialog 'Unsafe swap space detected'
  Installation is completely blocked because the partition is not released and cannot be reused.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1056707/+subscriptions