[Bug 1160288] Re: uninitialized value $3 / $curmod

[Steve Langasek]

Thanks, I've been able to reproduce the problem now, though it's rather
tricky - it requires both the libpam-sss package and the mkhomedir
profile that you have available locally, in order to reproduce this.
(It seems that the sss profiles you have on your system come from
precise-updates and don't look the same in the precise version of the
package; however, this apparently has no bearing on the problem.)

Essentially, this is a problem with the handling of trailing whitespace
in the pam config (/usr/share/pam-configs/mkhomedir has a whitespace-
only line at the end of the file).  pam-auth-update should be fixed to
ignore such blank lines, and not store them to /var/lib/pam/foo, which
is where the problem arises.

** Changed in: pam (Ubuntu)
       Status: Incomplete => Triaged

** Changed in: pam (Ubuntu)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pam in Ubuntu.
https://bugs.launchpad.net/bugs/1160288

Title:
  uninitialized value $3 / $curmod

Status in “pam” package in Ubuntu:
  Triaged

Bug description:
  [impact]
  Call of pam-auth-update raises some warnings of uninitalized variables

  [test case]
  install sssd libpam-sss libnss-sss and run pam-auth-update

  [versions]
  Distributor ID: Ubuntu
  Description:    Ubuntu 12.04.2 LTS
  Release:        12.04
  Codename:       precise

  libpam-runtime
  1.1.3-7ubuntu2

  
  [possible solution]
  --- a/pam-auth-update   Tue Mar 26 11:05:37 2013 +0100
  +++ b/pam-auth-update   Tue Mar 26 11:05:56 2013 +0100
  @@ -620,8 +620,8 @@
                                  ($modname,$line) = @{$saved[0]};
                                  shift(@saved);
                                  $line =~ /^((\[[^]]+\]|\w+)\s+\S+)\s*(.*)/;
  -                               @prev_opts = split(/\s+/,$3);
  -                               $curmod = $1;
  +                               @prev_opts = split(/\s+/, (defined $3?$3:"") );
  +                               $curmod = (defined $1?$1:"");
                                  # FIXME: the key isn't derived from the config
                                  # name, so collisions are possible if more
                                  # than one config references the same module

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pam/+bug/1160288/+subscriptions