[Bug 1256565] Re: apt-key del gives wrong message if key is not in keyring

[David Kalnischkies]

If we have an error message, the exit code should be non-zero, but we
can't do this without surprising users (read: scripts).

While it might not be perfect, it is at least not wrong as 'del' does in
this situation what it is supposed to do: remove the key from the
keyring. This is a trivial task of course if the key isn't present
before, but so it be: After the request the key is (still) removed.

Are you needing this for anything or was it just "surprising the first
time round"?

Note btw that the remove_key_from_keyring function is called multiple
times with different keyrings as keys can (not) be in different keyrings
nowadays which all need to be inspected, so apt-key would have to keep
track of how often it has nuked a key from a keyring so far adding lots
of code for the small gain of printing an error message telling me that
I wasted precious lifetime typing a command which boiled down to being a
no-operation (and wasted another bunch of seconds on reading the error
message).

[Bad enough that it prints "OK". It should really be silent…]

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1256565

Title:
  apt-key del gives wrong message if key is not in keyring

Status in “apt” package in Ubuntu:
  New

Bug description:
  If an attempt is made to remove a key that is already not on the list of trusted keys, apt-key gives no indication that the key 
  was not found.  Instead it says "OK" no matter what:

   # apt-key del 40976EAF437BBBBB
   OK
   # apt-key list | grep 40976EAF437BBBBB
   # apt-key list | grep 40
   pub   4096R/C0B21F32 2012-05-11
   pub   4096R/EFE21092 2012-05-11
   # apt-key del 40976EAF437BBBBB
   OK

  What should happen when an attempt is made to delete a key that is not
  found among the list of trusted keys is that apt-key should complain
  with some other message than "OK".  Maybe a "Key not found" message
  would be appropriate.

  ProblemType: Bug
  DistroRelease: Ubuntu 14.04
  Package: apt 0.9.13~exp1ubuntu2
  ProcVersionSignature: Ubuntu 3.12.0-3.8-generic 3.12.0
  Uname: Linux 3.12.0-3-generic x86_64
  ApportVersion: 2.12.7-0ubuntu1
  Architecture: amd64
  CurrentDesktop: LXDE
  Date: Sat Nov 30 22:18:39 2013
  InstallationDate: Installed on 2013-11-19 (11 days ago)
  InstallationMedia: Lubuntu 14.04 "Trusty Tahr" - Alpha amd64+mac (20131118)
  SourcePackage: apt
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1256565/+subscriptions