[Bug 1123588] Re: [4.7 Regression] wrong code with the fix for PR53844

[Matthias Klose]

according to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56301#c3 this
is not an issue with GCC, but job_new shouldn't be marked with the
malloc attribute. The following patch lets the test case pass without
the GCC change reverted. Maybe other usages of the malloc attribute
should be revisited.

 --- init/job.h.orig     2012-12-04 17:14:47.000000000 +0000
+++ init/job.h  2013-02-18 13:06:31.792691230 +0000
@@ -165,7 +165,7 @@
 NIH_BEGIN_EXTERN
 
 Job *       job_new             (JobClass *class, const char *name)
-       __attribute__ ((warn_unused_result, malloc));
+       __attribute__ ((warn_unused_result));
 void        job_register        (Job *job, DBusConnection *conn, int signal);
 
 void        job_change_goal     (Job *job, JobGoal goal);


** Changed in: upstart (Ubuntu)
       Status: Confirmed => Triaged

** Changed in: upstart (Ubuntu)
   Importance: Undecided => High

** Changed in: upstart (Ubuntu)
     Assignee: (unassigned) => James Hunt (jamesodhunt)

** Changed in: gcc-4.7 (Ubuntu)
       Status: Confirmed => Invalid

** Also affects: upstart (Ubuntu Raring)
   Importance: High
     Assignee: James Hunt (jamesodhunt)
       Status: Triaged

** Also affects: gcc-4.7 (Ubuntu Raring)
   Importance: Undecided
       Status: Invalid

** Changed in: upstart (Ubuntu Raring)
    Milestone: None => ubuntu-13.04-beta-1

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to upstart in Ubuntu.
https://bugs.launchpad.net/bugs/1123588

Title:
   [4.7 Regression] wrong code with the fix for PR53844

Status in The GNU Compiler Collection:
  Incomplete
Status in “gcc-4.7” package in Ubuntu:
  Invalid
Status in “upstart” package in Ubuntu:
  Triaged
Status in “gcc-4.7” source package in Raring:
  Invalid
Status in “upstart” source package in Raring:
  Triaged

Bug description:
  seen with -21ubuntu1, not with -20ubuntu1, reverting the fix for
  PR53844 avoids the issue.

  I think we need a reproducer in upstart, which doesn't just hang.

To manage notifications about this bug go to:
https://bugs.launchpad.net/gcc/+bug/1123588/+subscriptions