[Bug 1123460] Re: verify-signature crashes on non ascii characters

[Reagan Sanders]

patch fixing the UTF issue. We were trying to stick the UTF strings from
the GPG subsystem into plain ASCII format strings. Changed the format
strings to be UTF as well. His test branch seems to work fine now.

** Patch added: "bzr_verify_signature_utf_fix.patch"
   https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+attachment/3751719/+files/bzr_verify_signature_utf_fix.patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to bzr in Ubuntu.
https://bugs.launchpad.net/bugs/1123460

Title:
  verify-signature crashes on non ascii characters

Status in “bzr” package in Ubuntu:
  Confirmed

Bug description:
  first : on "bzr verify-signatures -v" i get :
  bzr: ERROR: exceptions.TypeError: can only concatenate list (not "str") to list

  Traceback (most recent call last):
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 920, in exception_to_return_code
      return the_callable(*args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 1131, in run_bzr
      ret = run(*run_argv)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 673, in run_argv_aliases
      return self.run(**all_cmd_args)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 695, in run
      return self._operation.run_simple(*args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 136, in run_simple
      self.cleanups, self.func, *args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 166, in _do_with_cleanups
      result = func(*args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/commit_signature_commands.py", line 170, in run
      write(gpg_strategy.verbose_valid_message(result))
    File "/usr/lib/python2.7/dist-packages/bzrlib/commit_signature_commands.py", line 130, in write
      self.outf.write(string + "\n")
  TypeError: can only concatenate list (not "str") to list



  
  maybe a little more straight-forward; if I do "bzr qlog" then click on a revision, i get :

  bzr: ERROR: exceptions.UnicodeEncodeError: 'ascii' codec can't encode
  character u'\xe7' in position 4: ordinal not in range(128)

  Traceback (most recent call last):
    File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/util.py", line 908, in run_in_loading_queue
      f(*args, **kargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/uifactory.py", line 32, in decorate
      r = f(*args, **kargs)
    File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/revisionmessagebrowser.py", line 365, in update_selection
      revids, self.log_list.log_model.graph_viz.get_repo_revids)
    File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/revisionmessagebrowser.py", line 149, in set_display_revids
      pass_prev_loaded_rev=True)
    File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/lazycachedrevloader.py", line 53, in load_revisions
      revisions_loaded(return_revisions, False)
    File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/revisionmessagebrowser.py", line 204, in revisions_loaded
      cached_revisions[revid].repository)
    File "/usr/lib/python2.7/dist-packages/bzrlib/log.py", line 346, in format_signature_validity
      return "valid signature from {0}".format(result[1])
  UnicodeEncodeError: 'ascii' codec can't encode character u'\xe7' in position 4: ordinal not in range(128)

  bzr 2.5.1 on python 2.7.3 (Linux-3.2.0-38-generic-x86_64-with-
      Ubuntu-12.04-precise)
  arguments: ['/usr/bin/bzr', 'qlog']
  plugins: bash_completion[2.5.1], bzrtools[2.5.0], changelog_merge[2.5.1],
      explorer[1.2.2], launchpad[2.5.1], netrc_credential_store[2.5.1],
      news_merge[2.5.1], po_merge[2.5.1], qbzr[0.22.2], upload[1.1.0],
      weave_fmt[2.5.1], webdav[1.12.2]
  encoding: 'utf-8', fsenc: 'UTF-8', lang: 'en_CA.UTF-8'


  Sorry, my name hapens to be utf-8 !!!

  ProblemType: Bug
  DistroRelease: Ubuntu 12.04
  Package: bzr 2.5.1-0ubuntu2
  ProcVersionSignature: Ubuntu 3.2.0-38.59-generic 3.2.37
  Uname: Linux 3.2.0-38-generic x86_64
  NonfreeKernelModules: nvidia
  ApportVersion: 2.0.1-0ubuntu17.1
  Architecture: amd64
  CheckboxSubmission: 07acc21e2cd262f4bfdaa4e25a19f966
  CheckboxSystem: 2a6f54df59af338184485e85cbcf0d32
  Date: Tue Feb 12 15:47:08 2013
  InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Release amd64 (20101007)
  MarkForUpload: True
  PackageArchitecture: all
  ProcEnviron:
   TERM=xterm
   PATH=(custom, no user)
   LANG=en_CA.UTF-8
   SHELL=/bin/bash
  SourcePackage: bzr
  UpgradeStatus: Upgraded to precise on 2012-06-05 (252 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+subscriptions