[Bug 933943]

Theinric 933943 at bugs.launchpad.net
Mon Mar 18 17:01:11 UTC 2013


Hi, I have several remarks.

There's a potential for an endless loop in not so unrealistic
conditions.

Every other error besides ERANGE causes this. E.g. referencing a non-
existent group. Others can be caused by missing permissions, wrong
configuration in /etc/nsswitch.conf, etc.

Attached is a patch that should mitigate this. Manpages are a bit
ambiguous about how getgrnam_r() reports errors, but it looks safe to
ignore errno completely and rely on the return code.

The patch is for 5.10.2 but the code in v7 is almost identical.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to rsyslog in Ubuntu.
https://bugs.launchpad.net/bugs/933943

Title:
  rsyslogd please apply patch for large group handling

Status in Rsyslog:
  Confirmed
Status in “rsyslog” package in Ubuntu:
  Triaged

Bug description:
  http://bugzilla.adiscon.com/show_bug.cgi?id=310

  rsyslog uses a static 2048 character buffer to perform group lookups.
  Some of us have large groups and need a larger buffer. This patch
  repeatedly calls getgrnam_r until it gets a buffer of sufficient size.

  -A

To manage notifications about this bug go to:
https://bugs.launchpad.net/rsyslog/+bug/933943/+subscriptions




More information about the foundations-bugs mailing list