[Bug 1244763] [NEW] devpts is mounted incorrectly in the non-initrd case

[Adam Conrad]

Public bug reported:

In most places in Ubuntu, devpts is mounted correctly with
gid=5,mode=620, however upstart itself mounts it incorrectly in the
cases when it's not already mounted by something else:

init/main.c:            if (system_mount ("devpts", "/dev/pts",
(MS_NOEXEC | MS_NOSUID)) < 0)

Compare to, say, systemd, which does this:


#ifndef TTY_GID
#define TTY_GID 5
#endif
[...]
src/core/mount-setup.c: { "devpts",     "/dev/pts",                  "devpts",     "mode=620,gid=" STRINGIFY(TTY_GID), MS_NOSUID|MS_NOEXEC,

Please fix this up, as this will explode in special and fun ways when
pt_chown goes away and we stop falling back on it as a crutch when the
devpts permissions are wrong.

** Affects: upstart
     Importance: Undecided
         Status: New

** Affects: upstart (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to upstart in Ubuntu.
https://bugs.launchpad.net/bugs/1244763

Title:
  devpts is mounted incorrectly in the non-initrd case

Status in Upstart:
  New
Status in “upstart” package in Ubuntu:
  New

Bug description:
  In most places in Ubuntu, devpts is mounted correctly with
  gid=5,mode=620, however upstart itself mounts it incorrectly in the
  cases when it's not already mounted by something else:

  init/main.c:            if (system_mount ("devpts", "/dev/pts",
  (MS_NOEXEC | MS_NOSUID)) < 0)

  Compare to, say, systemd, which does this:

  
  #ifndef TTY_GID
  #define TTY_GID 5
  #endif
  [...]
  src/core/mount-setup.c: { "devpts",     "/dev/pts",                  "devpts",     "mode=620,gid=" STRINGIFY(TTY_GID), MS_NOSUID|MS_NOEXEC,

  Please fix this up, as this will explode in special and fun ways when
  pt_chown goes away and we stop falling back on it as a crutch when the
  devpts permissions are wrong.

To manage notifications about this bug go to:
https://bugs.launchpad.net/upstart/+bug/1244763/+subscriptions