[Bug 1271141] Re: 30_os-prober fails in make_timeout() when using GRUB_BUTTON_CMOS_ADDRESS

[TJ]

Looks to be solved. The generated grub script:

if cmostest 85:3 ; then
   set default="0"
elif [ "${next_entry}" ] ; then
   set default="${next_entry}"
   set next_entry=
   save_env next_entry
   set boot_once=true
else
   set default="0"
fi


** Changed in: grub2 (Ubuntu)
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to grub2 in Ubuntu.
https://bugs.launchpad.net/bugs/1271141

Title:
  30_os-prober fails in make_timeout() when using
  GRUB_BUTTON_CMOS_ADDRESS

Status in “grub2” package in Ubuntu:
  Fix Released

Bug description:
  I've been configuring the alternate OS boot functionality and
  discovered that "30_os-prober" causes a syntax error in the generated
  "grub.cfg.new" when GRUB_BUTTON_CMOS_ADDRESS is defined. The bad
  generated code is:

  if cmostest 85:3; then
  else
  fi

  It is obviously missing any statements inside the conditional blocks.

  The cause  is make_timeout() only generating output when
  "$found_other_os" is empty. In the case of using
  GRUB_BUTTON_CMOS_ADDRESS its entire purpose is to use the alternative
  OS boot button that some PCs have.

  I'll do a merge request later but the quick-fix to "/etc/grub/30_os-
  prober" is:

  make_timeout() {
    if [ "x${found_other_os}" = "x" -o "x${GRUB_BUTTON_CMOS_ADDRESS}" != "x" ]; then

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1271141/+subscriptions