[Bug 1315200] [NEW] autopilot-touch/apparmor/click.rules need a new home, but where?

[Sergio Schvezov]

On Thu, May 1, 2014 at 9:00 PM, Dimitri John Ledkov
<launchpad at surgut.co.uk>wrote:

> Public bug reported:
>
> autopilot-touch/apparmor/click.rules need a new home, but where?
>
> At the moment click.rules is executed by phablet-config on the touch
> image:
>
> <xnox> def _handle_autopilot(adb, args):
> <xnox>     if args.dbus_probe == 'enable':
> <xnox>         rfile = '/usr/share/autopilot-touch/apparmor/click.rules'
> <xnox>         adb.shell('aa-clickhook -f --include=%s' % rfile)
> <xnox>     else:
> <xnox>         adb.shell('aa-clickhook -f')
>
> The file itself is at the moment shipped by package autopilot-touch ->
> which is an unfortunate meta-package which really has no valid reasons
> to exist, e.g. all those dependencies are seeded in ubuntu-touch seed
> anyway.
>
> The name of the rules file is also a bit missleading, it would be better
> named dbus-autopilot or some such.
>
> Depending on what we choose to do autopilot, phablet-tools, click-
> apparmor, may need to change.
>
> option1: move /usr/share/autopilot-touch/apparmor/click.rules to be
> shipped by apparmor-click package instead of autopilot-touch package
>
> option2: ship a new rules file in click-apparmor package (e.g. usr/share
> /click-apparmor/dbus-autopilot.rules), add support in phablet tools to
> execute with both old and new name, eventually deprecate/drop autopilot-
> touch package
>
> option3: have python-autopilot ship python-autopilot.rules &
> python3-autopilot ship python3-autopilot.rules & teach phablet-config to
> call/include either.
>
> option4: simply make python3-autopilot ship that rules file, in that
> same location.
>
> option5: use some other mechanism to ship equivalent click.rules, but
> disabled by default, and calls to enable/disable it.
>

option6: add to phablet-tools and have it push the rules file and rerun the
hooks?


>
> Or any other options that you may suggest
>
> for reference here is the contents of the click.rules:
> dbus (receive, send)
>      bus=session
>      path=/com/canonical/Autopilot/**,
>
> ** Affects: autopilot (Ubuntu)
>      Importance: Undecided
>          Status: New
>
> ** Affects: click-apparmor (Ubuntu)
>      Importance: Undecided
>          Status: New
>
> ** Affects: phablet-tools (Ubuntu)
>      Importance: Undecided
>          Status: New
>
> ** Also affects: click-apparmor (Ubuntu)
>    Importance: Undecided
>        Status: New
>
> ** Also affects: autopilot (Ubuntu)
>    Importance: Undecided
>        Status: New
>
> --
> You received this bug notification because you are subscribed to
> phablet-tools in Ubuntu.
> https://bugs.launchpad.net/bugs/1315200
>
> Title:
>   autopilot-touch/apparmor/click.rules need a new home, but where?
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/autopilot/+bug/1315200/+subscriptions
>

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-meta in Ubuntu.
https://bugs.launchpad.net/bugs/1315200

Title:
  autopilot-touch/apparmor/click.rules need a new home, but where?

Status in “autopilot” package in Ubuntu:
  New
Status in “click-apparmor” package in Ubuntu:
  Invalid
Status in “phablet-tools” package in Ubuntu:
  Invalid
Status in “ubuntu-meta” package in Ubuntu:
  Fix Released

Bug description:
  autopilot-touch/apparmor/click.rules need a new home, but where?

  At the moment click.rules is executed by phablet-config on the touch
  image:

  <xnox> def _handle_autopilot(adb, args):
  <xnox>     if args.dbus_probe == 'enable':
  <xnox>         rfile = '/usr/share/autopilot-touch/apparmor/click.rules'
  <xnox>         adb.shell('aa-clickhook -f --include=%s' % rfile)
  <xnox>     else:
  <xnox>         adb.shell('aa-clickhook -f')

  The file itself is at the moment shipped by package autopilot-touch ->
  which is an unfortunate meta-package which really has no valid reasons
  to exist, e.g. all those dependencies are seeded in ubuntu-touch seed
  anyway.

  The name of the rules file is also a bit missleading, it would be
  better named dbus-autopilot or some such.

  Depending on what we choose to do autopilot, phablet-tools, click-
  apparmor, may need to change.

  option1: move /usr/share/autopilot-touch/apparmor/click.rules to be
  shipped by apparmor-click package instead of autopilot-touch package

  option2: ship a new rules file in click-apparmor package (e.g.
  usr/share/click-apparmor/dbus-autopilot.rules), add support in phablet
  tools to execute with both old and new name, eventually deprecate/drop
  autopilot-touch package

  option3: have python-autopilot ship python-autopilot.rules &
  python3-autopilot ship python3-autopilot.rules & teach phablet-config
  to call/include either.

  option4: simply make python3-autopilot ship that rules file, in that
  same location.

  option5: use some other mechanism to ship equivalent click.rules, but
  disabled by default, and calls to enable/disable it.

  Or any other options that you may suggest

  for reference here is the contents of the click.rules:
  dbus (receive, send)
       bus=session
       path=/com/canonical/Autopilot/**,

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/autopilot/+bug/1315200/+subscriptions