[Bug 1268134] Re: additional drivers tab crashes

[Joakim Fogelström Hardingz]

And btw, i revise my statement a bit about when the bug gets triggered:

Looking at the code:

[code]
# gather driver description
            if current_driver['free']:
                licence = _("open source")
            else:
                licence = _("proprietary")

            if driver_status == 'recommended':
                base_string = _("{base_description} ({licence}, tested)")
            else:
                base_string = _("{base_description} ({licence})")
            description = base_string.format(base_description=description, licence=licence)

            selected = False
            if not builtin and not returned_drivers['manually_installed']:
                selected = installed
                if installed:
                    selected = True
                    one_selected = True

            returned_drivers[driver_status].setdefault(pkg_driver_name, {'selected': selected,
                                                                         'description': description,
                                                                         'builtin': builtin})
[/code]

The bug should get triggered only when the driver is "recommended" by
Ubuntu devs? Could you confirm this?

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/1268134

Title:
  additional drivers tab crashes

Status in “software-properties” package in Ubuntu:
  Confirmed

Bug description:
  There's a crash every time I open the additional drivers tab in
  software properties. It says "searching for additional drivers" and
  then the crash happens. I can reproduce it every time I try to open
  the additional drivers tab, which means the additional drivers tab
  doesn't work at all for me.

  No drivers are shown in the list, and when running software-
  properties-gtk from the terminal I can see the following output:

  Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/gi/overrides/GLib.py", line 634, in <lambda>
      return (lambda data: callback(*data), user_data)
    File "/usr/lib/python3/dist-packages/softwareproperties/gtk/SoftwarePropertiesGtk.py", line 1323, in show_drivers
      (overall_status, icon, drivers) = self.gather_device_data(self.devices[device])
    File "/usr/lib/python3/dist-packages/softwareproperties/gtk/SoftwarePropertiesGtk.py", line 1277, in gather_device_data
      description = base_string.format(base_description=description, licence=licence)
  KeyError: 'license'

  Ubuntu release:
  Description:	Ubuntu 13.10
  Release:	13.10

  software-properties-gtk version 0.92.28

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1268134/+subscriptions