[Bug 1411088] Re: when clicking on "Erase Disk" get DBus Attribute Error after authenticating

[Brian Murray]

[  9:24AM ]  [ bdmurray at impulse:~/source-trees/usb-creator/trunk ]
 $ bzr log -r446 -p
------------------------------------------------------------
revno: 446
committer: Dimitri John Ledkov <dimitri.ledkov at canonical.com>
branch nick: usb-creator
timestamp: Tue 2014-07-22 18:37:18 +0100
message:
  Correctly detect partition-table less parent devices.
diff:
=== modified file 'bin/usb-creator-helper'
--- bin/usb-creator-helper      2014-07-20 21:47:41 +0000
+++ bin/usb-creator-helper      2014-07-22 17:37:18 +0000
@@ -46,6 +46,8 @@
     if obj.get_partition_table():
         return obj
     partition = obj.get_partition()
+    if not partition:
+        return obj
     parent = partition.get_cached_property('Table').get_string()    
     return udisks.get_object(parent)
     

=== modified file 'debian/changelog'
--- debian/changelog    2014-07-20 21:47:49 +0000
+++ debian/changelog    2014-07-22 17:37:18 +0000
@@ -1,3 +1,9 @@
+usb-creator (0.2.60) UNRELEASED; urgency=medium
+
+  * Correctly detect partition-table less parent devices.
+
+ -- Dimitri John Ledkov <xnox at ubuntu.com>  Tue, 22 Jul 2014 18:37:00 +0100
+

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to usb-creator in Ubuntu.
https://bugs.launchpad.net/bugs/1411088

Title:
  when clicking on "Erase Disk" get DBus Attribute Error after
  authenticating

Status in usb-creator package in Ubuntu:
  Fix Released

Bug description:
  startup usb-creator-gtk with this command line:

  $ usb-creator-gtk -i ~/Desktop/KNOPPIX_V7.2.0CD-2013-06-16-EN.iso
  --show-all

  A popup window appears (behind all other windows, so you often can't even see it) asking you
  to authenticate.  Type in your password, and error window pops up with this text:

  org.freedesktop.DBus.Python.AttributeError: Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/dbus/service.py", line 707, in _message_cb
      retval = candidate_method(self, *args, **keywords)
    File "/usr/share/usb-creator/usb-creator-helper", line 218, in Format
      parent_dev = _get_parent_object(udisks, device)
    File "/usr/share/usb-creator/usb-creator-helper", line 49, in _get_parent_object
      parent = partition.get_cached_property('Table').get_string()
  AttributeError: 'NoneType' object has no attribute 'get_cached_property'

  
  Application window indicates that it is erasing the disk, but it is not.

  Application completely non-functional at this point.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/usb-creator/+bug/1411088/+subscriptions