[Bug 1454735] Re: adt-run doesn't realize the phone is not rebooting

[Vincent Ladeuil]

=== modified file 'lib/VirtSubproc.py'
--- lib/VirtSubproc.py	2015-05-11 08:39:02 +0000
+++ lib/VirtSubproc.py	2015-05-14 10:07:42 +0000
@@ -328,7 +328,7 @@
         adtlog.info('state saved, waiting for testbed to reboot...')
     else:
         execute_timeout(None, 30,
-                        auxverb + ['sh', '-c', '(sleep 3; reboot) &'])
+                        auxverb + ['sh', '-c', 'reboot'])

works.

But there is probably a good reason to use this form :-/

Note that I got there by running:

phablet at ubuntu-phablet:/tmp$ SUDO_ASKPASS=/tmp/sudo_askpass.yjKC sudo -A /tmp/adt-run-wrapper sh -c (sleep 3; reboot)
t-run-wrapper sh -c (sleep 3; reboot)
bash: syntax error near unexpected token `('

Oops

phablet at ubuntu-phablet:/tmp$ SUDO_ASKPASS=/tmp/sudo_askpass.yjKC sudo -A /tmp/adt-run-wrapper sh -c '(sleep 3; reboot)'
t-run-wrapper sh -c '(sleep 3; reboot)'

that one hangs

So the patch above just got rid of the sleep and the '&' but they may be
needed in other contexts.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to autopkgtest in Ubuntu.
https://bugs.launchpad.net/bugs/1454735

Title:
  adt-run doesn't realize the phone is not rebooting

Status in autopkgtest package in Ubuntu:
  New

Bug description:
  From https://code.launchpad.net/~canonical-platform-qa/unity8/1421009
  -hangs-on-boot/

  Running: 
    adt-run -d -B --unbuilt-tree . -o ~/ci/unity8/results-$(date +%Y-%m-%d-%H-%M) --- ssh -s adb -- -p 0000 --serial 04f55a0bc855b2bc

  happily proceed without the phone rebooting at all

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/autopkgtest/+bug/1454735/+subscriptions