[Bug 1516959] [NEW] debian/test/control: negative architecture restictions are rejected in dependencies

[Andy Whitcroft]

Public bug reported:

If we specify a negative architecture dependency in debian/test/control
we get an invalid syntax error:

    blame: linux
    badpkg: InvalidControl test ubuntu-regression-suite: Test Depends field contains an invalid dependency `gcc-multilib [!ppc64el]'
    adt-run [21:27:37]: ERROR: erroneous package: InvalidControl test ubuntu-regression-suite: Test Depends field contains an
       invalid dependency `gcc-multilib [!ppc64el]'
    Exit request sent.

This appears to be because ! is simply not expected by the parser:

lib/testdesc.py:
dep_re = re.compile(
    r'(?P<package>[a-z0-9+-.]+)(?::native)?\s*'
    r'(\((?P<relation><<|<=|>=|=|>>)\s*(?P<version>[^\)]*)\))?'
    r'(\s*\[[[a-z0-9+-. ]+\])?$')

Full log:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac
/autopkgtest-xenial-canonical-kernel-team-
unstable/xenial/i386/l/linux/20151113_212749@/log.gz

** Affects: autopkgtest (Ubuntu)
     Importance: Medium
     Assignee: Martin Pitt (pitti)
         Status: In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to autopkgtest in Ubuntu.
https://bugs.launchpad.net/bugs/1516959

Title:
  debian/test/control: negative architecture restictions are rejected in
  dependencies

Status in autopkgtest package in Ubuntu:
  In Progress

Bug description:
  If we specify a negative architecture dependency in
  debian/test/control we get an invalid syntax error:

      blame: linux
      badpkg: InvalidControl test ubuntu-regression-suite: Test Depends field contains an invalid dependency `gcc-multilib [!ppc64el]'
      adt-run [21:27:37]: ERROR: erroneous package: InvalidControl test ubuntu-regression-suite: Test Depends field contains an
         invalid dependency `gcc-multilib [!ppc64el]'
      Exit request sent.

  This appears to be because ! is simply not expected by the parser:

  lib/testdesc.py:
  dep_re = re.compile(
      r'(?P<package>[a-z0-9+-.]+)(?::native)?\s*'
      r'(\((?P<relation><<|<=|>=|=|>>)\s*(?P<version>[^\)]*)\))?'
      r'(\s*\[[[a-z0-9+-. ]+\])?$')

  Full log:
  https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac
  /autopkgtest-xenial-canonical-kernel-team-
  unstable/xenial/i386/l/linux/20151113_212749@/log.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/autopkgtest/+bug/1516959/+subscriptions