[Bug 1517545] [NEW] Grub2 does not understand lilo.conf on Salix

[kengo_shimane]

Public bug reported:

Grub2 does not understand lilo.conf on Salix.

Bug

I got error message when I tried to update-grub on Ubuntu 14.04 with os-
prober;

========
error: out of memory
error: syntax error
error: Incorrect command
Syntax error in line 274
========

Line 274 is located at the last line of grub.cfg.new, which I did not understand why out of memory.
However, I found a syntax error on the line for 30_os-prober section, where a double quotation was disappeared at the kernel option for Salix.

========
menuentry 'Slackware Linux (Slackware 14.1) (on /dev/sda2)' --class gnu-linux --class gnu --class os $menuentry_id_option 'osprober-gnulinux-simple-06ea6304-df14-4be6-8b42-defb07a91323' {
 insmod part_msdos
 insmod ext2
 set root='hd0,msdos2'
 if [ x$feature_platform_search_hint = xy ]; then
   search --no-floppy --fs-uuid --set=root --hint-bios=hd0,msdos2 --hint-efi=hd0,msdos2 --hint-baremetal=ahci0,msdos2  06ea6304-df14-4be6-8b42-defb07a91323
 else
   search --no-floppy --fs-uuid --set=root 06ea6304-df14-4be6-8b42-defb07a91323
 fi
 linux /boot/vmlinuz-huge-3.10.17 root=/dev/sda2 ro append = "vt.default_utf8=1  vga = normal
}
submenu 'Advanced options for Slackware Linux (Slackware 14.1) (on /dev/sda2)' $menuentry_id_option 'osprober-gnulinux-advanced-06ea6304-df14-4be6-8b42-defb07a91323' {
 menuentry 'Salix_Mate_14.1 (on /dev/sda2)' --class gnu-linux --class gnu --class os $menuentry_id_option 'osprober-gnulinux-/boot/vmlinuz-huge-3.10.17--06ea6304-df14-4be6-8b42-defb07a91323' {
  insmod part_msdos
  insmod ext2
  set root='hd0,msdos2'
  if [ x$feature_platform_search_hint = xy ]; then
    search --no-floppy --fs-uuid --set=root --hint-bios=hd0,msdos2 --hint-efi=hd0,msdos2 --hint-baremetal=ahci0,msdos2  06ea6304-df14-4be6-8b42-defb07a91323
  else
    search --no-floppy --fs-uuid --set=root 06ea6304-df14-4be6-8b42-defb07a91323
  fi
  linux /boot/vmlinuz-huge-3.10.17 root=/dev/sda2 ro append = "vt.default_utf8=1  vga = normal
 }
}
========

I had a Salix on the sda2 partition and os-prober did not succeed to get the correct variables from Salix boot directory.
This was confirmed because linux-boot-prober /dev/sda2 showed the same result:

========
/dev/sda2:/dev/sda2:Salix_Mate_14.1:/boot/vmlinuz-huge-3.10.17::root=/dev/sda2 ro append = "vt.default_utf8=1  vga = normal
========

Workaround

I configured LILO on Salix partition by editing lilo.conf to uncomment
append = "vt.default_utf8=1".

========
# append = "vt.default_utf8=1"
========

Then grub2 works well without error message and updates grub.cfg with
correct variables of kernel option for Salix.

========
linux /boot/vmlinuz-huge-3.10.17 root=/dev/sda2 ro vga = normal
========

Suggestions

I suggest the relevant scripts in 30_os-prober should be edited to
recognize correctly double quotation even if this is found on other boot
directory.

========
LPARAMS="`echo ${LINUX} | cut -d ':' -f 6- | tr '^' ' '`"      #This original, not edited yet, though.
========

** Affects: os-prober (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: grub2 lilo

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to os-prober in Ubuntu.
https://bugs.launchpad.net/bugs/1517545

Title:
  Grub2 does not understand lilo.conf on Salix

Status in os-prober package in Ubuntu:
  New

Bug description:
  Grub2 does not understand lilo.conf on Salix.

  Bug

  I got error message when I tried to update-grub on Ubuntu 14.04 with
  os-prober;

  ========
  error: out of memory
  error: syntax error
  error: Incorrect command
  Syntax error in line 274
  ========

  Line 274 is located at the last line of grub.cfg.new, which I did not understand why out of memory.
  However, I found a syntax error on the line for 30_os-prober section, where a double quotation was disappeared at the kernel option for Salix.

  ========
  menuentry 'Slackware Linux (Slackware 14.1) (on /dev/sda2)' --class gnu-linux --class gnu --class os $menuentry_id_option 'osprober-gnulinux-simple-06ea6304-df14-4be6-8b42-defb07a91323' {
   insmod part_msdos
   insmod ext2
   set root='hd0,msdos2'
   if [ x$feature_platform_search_hint = xy ]; then
     search --no-floppy --fs-uuid --set=root --hint-bios=hd0,msdos2 --hint-efi=hd0,msdos2 --hint-baremetal=ahci0,msdos2  06ea6304-df14-4be6-8b42-defb07a91323
   else
     search --no-floppy --fs-uuid --set=root 06ea6304-df14-4be6-8b42-defb07a91323
   fi
   linux /boot/vmlinuz-huge-3.10.17 root=/dev/sda2 ro append = "vt.default_utf8=1  vga = normal
  }
  submenu 'Advanced options for Slackware Linux (Slackware 14.1) (on /dev/sda2)' $menuentry_id_option 'osprober-gnulinux-advanced-06ea6304-df14-4be6-8b42-defb07a91323' {
   menuentry 'Salix_Mate_14.1 (on /dev/sda2)' --class gnu-linux --class gnu --class os $menuentry_id_option 'osprober-gnulinux-/boot/vmlinuz-huge-3.10.17--06ea6304-df14-4be6-8b42-defb07a91323' {
    insmod part_msdos
    insmod ext2
    set root='hd0,msdos2'
    if [ x$feature_platform_search_hint = xy ]; then
      search --no-floppy --fs-uuid --set=root --hint-bios=hd0,msdos2 --hint-efi=hd0,msdos2 --hint-baremetal=ahci0,msdos2  06ea6304-df14-4be6-8b42-defb07a91323
    else
      search --no-floppy --fs-uuid --set=root 06ea6304-df14-4be6-8b42-defb07a91323
    fi
    linux /boot/vmlinuz-huge-3.10.17 root=/dev/sda2 ro append = "vt.default_utf8=1  vga = normal
   }
  }
  ========

  I had a Salix on the sda2 partition and os-prober did not succeed to get the correct variables from Salix boot directory.
  This was confirmed because linux-boot-prober /dev/sda2 showed the same result:

  ========
  /dev/sda2:/dev/sda2:Salix_Mate_14.1:/boot/vmlinuz-huge-3.10.17::root=/dev/sda2 ro append = "vt.default_utf8=1  vga = normal
  ========

  Workaround

  I configured LILO on Salix partition by editing lilo.conf to uncomment
  append = "vt.default_utf8=1".

  ========
  # append = "vt.default_utf8=1"
  ========

  Then grub2 works well without error message and updates grub.cfg with
  correct variables of kernel option for Salix.

  ========
  linux /boot/vmlinuz-huge-3.10.17 root=/dev/sda2 ro vga = normal
  ========

  Suggestions

  I suggest the relevant scripts in 30_os-prober should be edited to
  recognize correctly double quotation even if this is found on other
  boot directory.

  ========
  LPARAMS="`echo ${LINUX} | cut -d ':' -f 6- | tr '^' ' '`"      #This original, not edited yet, though.
  ========

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1517545/+subscriptions