[Bug 1507886] Re: DistUpgradeFetcherKDE crashes on method _warning

[Harald Sitter]

Verified fixed with proposed. Upgrader doesn't crash but correctly
displays an error.

** Description changed:

  # Impact
  DistUpgradeFetcherKDE.py calls self._warning() but in fact _warning is not an instance method of the fetcher but rather a global helper. This causes early unhandled exceptions to entirely defunc the fetcher rendering upgrades with the KDE UI impossible. NB: this only happens iff there was a problem getting the release notes to begin with.
  
  This was fixed in https://launchpad.net/ubuntu/+source/ubuntu-release-
  upgrader/1:15.10.4 and needs to be SRU'd into vivid as it also suffers
  from the problem.
  
  # Test Case
+ - setup a apt-cacher-ng as proxy 
+ > $ cat /etc/apt/apt.conf.d/apt-cacher
+ > Acquire::http { Proxy "http://localhost:3142"; };
  - run `kdesudo -- do-release-upgrade -m desktop -f DistUpgradeViewKDE`
  - should come up with installer
  
  # Regression Potential
  Can't break anymore than getting another undefined method exception as we do now.
  
  # Other Info
  In testing I didn't actually get the fetcher UI itself to display, so I expect there is more wrong. It would however be a good start to not have it crash.

** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1507886

Title:
  DistUpgradeFetcherKDE crashes on method _warning

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Vivid:
  Fix Committed

Bug description:
  # Impact
  DistUpgradeFetcherKDE.py calls self._warning() but in fact _warning is not an instance method of the fetcher but rather a global helper. This causes early unhandled exceptions to entirely defunc the fetcher rendering upgrades with the KDE UI impossible. NB: this only happens iff there was a problem getting the release notes to begin with.

  This was fixed in https://launchpad.net/ubuntu/+source/ubuntu-release-
  upgrader/1:15.10.4 and needs to be SRU'd into vivid as it also suffers
  from the problem.

  # Test Case
  - setup a apt-cacher-ng as proxy 
  > $ cat /etc/apt/apt.conf.d/apt-cacher
  > Acquire::http { Proxy "http://localhost:3142"; };
  - run `kdesudo -- do-release-upgrade -m desktop -f DistUpgradeViewKDE`
  - should come up with installer

  # Regression Potential
  Can't break anymore than getting another undefined method exception as we do now.

  # Other Info
  In testing I didn't actually get the fetcher UI itself to display, so I expect there is more wrong. It would however be a good start to not have it crash.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1507886/+subscriptions