[Bug 1642903] Re: introduce disk/by-id (model_serial) symlinks for NVMe drives

[Dan Streetman]

I verified that the -proposed package does create the NVMe disk/by-id/ serial number symlink for each drive.  However, there's unfortunately a bug in the way it does it, which still exists upstream.  I opened this upstream udev bug for the problem:
https://github.com/systemd/systemd/issues/4833

The issue is any NVMe drives that include whitespace will break the way udev creates symlinks; e.g. if the model string is "XYZ Corp NVMe drive" then instead of creating:
/dev/disk/by-id/nvme-XYZ Corp NVMe drive_SERIAL -> ../../nvme0n1
it creates:
/dev/disk/by-id/nvme-XYZ -> ../../nvme0n1
/dev/Corp -> nvme0n1
/dev/NVMe -> nvme0n1
/dev/drive_SERIAL -> nvme0n1

So for NVMe drives that *do not* contain spaces in their model and
serial strings, the -proposed package works correctly, but for NVMe
drives that *do* contain spaces (or other chars that shouldn't be in a
symlink, e.g. /$%?,), the -proposed package will create incorrect
symlinks.

** Bug watch added: github.com/systemd/systemd/issues #4833
   https://github.com/systemd/systemd/issues/4833

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1642903

Title:
  introduce disk/by-id (model_serial) symlinks for NVMe drives

Status in systemd package in Ubuntu:
  Fix Released
Status in systemd source package in Trusty:
  In Progress
Status in systemd source package in Xenial:
  Fix Committed
Status in systemd source package in Yakkety:
  Fix Committed
Status in systemd source package in Zesty:
  Fix Released

Bug description:
  [Impact]

  NVMe drives can't be identified/accessed via /dev/disk/by-id/nvme-
  SERIAL symlinks.

  [Test Case]

  On a system with an NVMe drive, check the /dev/disk/by-id/ directory;
  with the patch, it will contain link(s) named by the drive serial
  number. This should be the *only* change in `ls -l /dev/disk/*/*`.

  On a system without NVMe, verify that `ls -l /dev/disk/*/*` is
  identical (aside from dates, of course) before and after the upgrade
  to the -proposed version.

  [Regression Potential]

  Errors in udev rules can lead to an unbootable or otherwise completely
  broken system if they unintentionally break or  clobber existing
  /dev/disks/ symlinks.

  [Other Info]

  This patch is already included upstream and in zesty systemd.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1642903/+subscriptions