[Bug 1579949] Re: add_gdb_info hides OSErrors when running gdb during retracing

[Launchpad Bug Tracker]

This bug was fixed in the package apport - 2.20.2-0ubuntu1

---------------
apport (2.20.2-0ubuntu1) yakkety; urgency=medium

  [ Brian Murray ]
  * data/general-hooks/ubuntu.py: tag bug reports 'apport-hook-error' if they
    have an attachment from an apport hook which crashed.

  [ Martin Pitt ]
  * New upstream release. Changes since our previous snapshot:
    - Don't ignore OSError in Report.add_gdb_info(), as we do want to fail with an
      useful error message if gdb cannot be called in apport-retrace. Move the
      catching to the UI as not having gdb installed is still fine for reporting
      clients. (LP: #1579949)
    - Show gdb error messages in Report.add_gdb_info() OSError exception when gdb
      fails. (LP: #1579897)
    - hookutils, attach_root_command_outputs(): Return str again, like before
      2.15.2. (LP: #1370259)
    - Stop issuing "set architecture" gdb commands on ARM and Power; these only
      applied to 32 bit platforms and are apparently not needed any more with
      recent gdb versions. (LP: #1585702)
    - Disable report.test_add_gdb_info_abort_libnih test case for now, as libnih
      is broken under current Ubuntu (LP: #1580601)

 -- Martin Pitt <martin.pitt at ubuntu.com>  Sun, 19 Jun 2016 22:17:35
+0200

** Changed in: apport (Ubuntu)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/1579949

Title:
  add_gdb_info hides OSErrors when running gdb during retracing

Status in Apport:
  Fix Released
Status in apport package in Ubuntu:
  Fix Released

Bug description:
  I've been trying to debug an issue with apport trunk and retracing
  crashes from Xenial.  Come to find out I was receiving an OSError when
  running gdb (see bug 1579897) but didn't know it because of this code
  in report.py's add_gdb_info.

   721         # call gdb
   722         try:
   723             out = _command_output(gdb_cmd).decode('UTF-8', errors='replace')
   724         except OSError:
   725             return

  If _command_output tries to raise an OSError, it seems to me like we
  shouldn't just return in line 725.

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/1579949/+subscriptions