[Bug 1595021] Re: Backport dh-golang 1.13 to trusty

[Martin Pitt]

Thanks for doing the rebuild check in advance, that's very convincing!

** Changed in: dh-golang (Ubuntu Trusty)
       Status: In Progress => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to dh-golang in Ubuntu.
https://bugs.launchpad.net/bugs/1595021

Title:
  Backport dh-golang 1.13 to trusty

Status in dh-golang package in Ubuntu:
  Invalid
Status in dh-golang source package in Trusty:
  Fix Committed

Bug description:
  [Impact]
  We want to backport docker and related packages to Trusty. The dh-golang in trusty is too old and lacks features used by the packages we want to backport (particularly the support for the  DH_GOLANG_BUILDPKG and DH_GOLANG_EXCLUDES variables to control which packages are built, but also the support for reading the Go import path from the control file).

  dh-golang is up to version 1.18 in sid/yakkety now but that causes 1
  package (ngrok) in trusty to ftbfs. 1.13 seems to be a sweet spot in
  terms of having features and fixes we need but not breaking any
  packages in trusty.

  [Test case]
  In fact, there is already a package in trusty that uses tries to use the newer features and has a bug as a result: golang-logrus builds an _all golang-logrus-dev package that contains a i386 binary:

  mwhudson at aeglos:~/tmp$ lintian golang-logrus-dev_0.7.3-1~ubuntu0.14.04.1_all.deb 
  E: golang-logrus-dev: arch-independent-package-contains-binary-or-object usr/bin/basic

  So a test case would be to rebuild this package and see if this
  lintian error goes away.

  [Regression potential]
  There is obviously some potential for regressions here, but I've rebuilt all reverse dependencies of dh-golang in trusty twice, once with the version of dh-golang in trusty:

      https://launchpad.net/~mwhudson/+archive/ubuntu/trusty-go-rebuilds

  and once with a backport of dh-golang 1.13:

      https://launchpad.net/~mwhudson/+archive/ubuntu/trusty-go-
  rebuilds-dh-golang-2

  I debmirror-ed both PPAs and compared the results (with find and
  debdiff). Apart from fixing the above bug in golang-logrus, the only
  differences are in golang-doozer, golang-openldap, and golang-
  goprotobuf-dev and are down to the fact that dh-golang now by default
  includes .proto, .c and .s files in -dev packages. This is at worst
  harmless and quite possibly would make the packages more useful.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dh-golang/+bug/1595021/+subscriptions