[Bug 1619453] [NEW] backport patch for Ticket#12371 on libboost-thread

[Guillaume W.]

Public bug reported:

On Xenial, while building code using boost thread like in
https://github.com/shadow-robot/sr_core/blob/indigo-
devel/sr_utilities/include/sr_utilities/thread_safe_map.hpp

I encountered this bug 
https://svn.boost.org/trac/boost/ticket/12371

{{{
In file included from /usr/include/boost/thread.hpp:24:0,
                 from /homes/guihome/work/dev/catkin_kinetic_shadow/src/shadow_robot/sr_core/sr_utilities/include/sr_utilities/thread_safe_map.hpp:32,
                 from /homes/guihome/work/dev/catkin_kinetic_shadow/src/shadow_robot_ethercat/sr_robot_lib/include/sr_robot_lib/sr_joint_motor.hpp:34,
                 from /homes/guihome/work/dev/catkin_kinetic_shadow/src/shadow_robot_ethercat/sr_tactile_sensor_controller/include/sr_tactile_sensor_controller/sr_tactile_calibration.hpp:13,
                 from /homes/guihome/work/dev/catkin_kinetic_shadow/src/shadow_robot_ethercat/sr_tactile_sensor_controller/src/sr_tactile_calibration.cpp:10:
/usr/include/boost/thread/future.hpp: In member function ‘void boost::detail::future_async_shared_state<Rp, Fp>::init(const Fp&)’:
/usr/include/boost/thread/future.hpp:788:32: error: expected primary-expression before ‘(’ token
             this->thr_ = thread(&future_async_shared_state::run, that, boost::forward<Fp>(f));
                                ^
/usr/include/boost/thread/future.hpp: In member function ‘void boost::detail::future_async_shared_state<void, Fp>::init(const Fp&)’:
/usr/include/boost/thread/future.hpp:810:32: error: expected primary-expression before ‘(’ token
             this->thr_ = thread(&future_async_shared_state::run, this->shared_from_this(), boost::move(f));
                                ^
/usr/include/boost/thread/future.hpp: In member function ‘void boost::detail::future_async_shared_state<Rp&, Fp>::init(const Fp&)’:
/usr/include/boost/thread/future.hpp:833:32: error: expected primary-expression before ‘(’ token
             this->thr_ = thread(&future_async_shared_state::run, this->shared_from_this(), boost::move(f));
                                ^
}}}

applying a similar patch to Ticket#12371 on 1.58 fixes the issue.


Might be a very specific use-case, but would be nice to backport this fix on LTS.

thanks

** Affects: boost1.58 (Ubuntu)
     Importance: Undecided
         Status: New

** Patch added: "add namespace to thread() calls"
   https://bugs.launchpad.net/bugs/1619453/+attachment/4732558/+files/boost_thread_namespace.patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to boost1.58 in Ubuntu.
https://bugs.launchpad.net/bugs/1619453

Title:
  backport patch for Ticket#12371 on libboost-thread

Status in boost1.58 package in Ubuntu:
  New

Bug description:
  On Xenial, while building code using boost thread like in
  https://github.com/shadow-robot/sr_core/blob/indigo-
  devel/sr_utilities/include/sr_utilities/thread_safe_map.hpp

  I encountered this bug 
  https://svn.boost.org/trac/boost/ticket/12371

  {{{
  In file included from /usr/include/boost/thread.hpp:24:0,
                   from /homes/guihome/work/dev/catkin_kinetic_shadow/src/shadow_robot/sr_core/sr_utilities/include/sr_utilities/thread_safe_map.hpp:32,
                   from /homes/guihome/work/dev/catkin_kinetic_shadow/src/shadow_robot_ethercat/sr_robot_lib/include/sr_robot_lib/sr_joint_motor.hpp:34,
                   from /homes/guihome/work/dev/catkin_kinetic_shadow/src/shadow_robot_ethercat/sr_tactile_sensor_controller/include/sr_tactile_sensor_controller/sr_tactile_calibration.hpp:13,
                   from /homes/guihome/work/dev/catkin_kinetic_shadow/src/shadow_robot_ethercat/sr_tactile_sensor_controller/src/sr_tactile_calibration.cpp:10:
  /usr/include/boost/thread/future.hpp: In member function ‘void boost::detail::future_async_shared_state<Rp, Fp>::init(const Fp&)’:
  /usr/include/boost/thread/future.hpp:788:32: error: expected primary-expression before ‘(’ token
               this->thr_ = thread(&future_async_shared_state::run, that, boost::forward<Fp>(f));
                                  ^
  /usr/include/boost/thread/future.hpp: In member function ‘void boost::detail::future_async_shared_state<void, Fp>::init(const Fp&)’:
  /usr/include/boost/thread/future.hpp:810:32: error: expected primary-expression before ‘(’ token
               this->thr_ = thread(&future_async_shared_state::run, this->shared_from_this(), boost::move(f));
                                  ^
  /usr/include/boost/thread/future.hpp: In member function ‘void boost::detail::future_async_shared_state<Rp&, Fp>::init(const Fp&)’:
  /usr/include/boost/thread/future.hpp:833:32: error: expected primary-expression before ‘(’ token
               this->thr_ = thread(&future_async_shared_state::run, this->shared_from_this(), boost::move(f));
                                  ^
  }}}

  applying a similar patch to Ticket#12371 on 1.58 fixes the issue.

  
  Might be a very specific use-case, but would be nice to backport this fix on LTS.

  thanks

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/boost1.58/+bug/1619453/+subscriptions