[Bug 1709029] Re: Tests failing on xenial due to missing fakeroot command

[Steve Langasek]

Hello Łukasz, or anyone else affected,

Accepted ubuntu-image into xenial-proposed. The package will build now
and be available at https://launchpad.net/ubuntu/+source/ubuntu-
image/1.1+16.04ubuntu4 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-xenial to verification-done-xenial. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-xenial. In either case, details of your
testing will help us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: ubuntu-image (Ubuntu Xenial)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-image in Ubuntu.
https://bugs.launchpad.net/bugs/1709029

Title:
  Tests failing on xenial due to missing fakeroot command

Status in Ubuntu Image:
  In Progress
Status in ubuntu-image package in Ubuntu:
  Fix Released
Status in ubuntu-image source package in Xenial:
  Fix Committed

Bug description:
  [Impact]

  Currently the xenial ubuntu-image package fails autopkgtests due to
  the missing fakeroot dependency. Xenial has an older mkfs.ext4 that
  does not support a parameter that all the other series are using.
  Because of that, fakeroot is not really used on this release as by
  default the first call of mkfs.ext4 which is assuming the existence of
  the '-d' option is supposed to fail and then u-i is moving on to using
  a fallback method of copying rootfs contents into the filesystem. To
  the first call of the mkfs.ext4 call we have recently added fakeroot
  (due to a security vulnerability discovered).

  The failure of calling mkfs.ext4 with an unrecognized parameter and
  calling fakeroot mkfs.ext4 when fakeroot is not installed both
  generate different errors (the first one causes run() to exit with
  error and the second one rises a FileNotFoundError exception). We can
  easily support both cases, but then we are encountering code coverage
  issues - as in the best case we want to have the same code for all
  supported series. It's not easy to mock this case in unit tests as in
  theory we will never be able to reach this FileNotFoundError branch on
  non-xenial systems. It basically requires a lot of unnecessary work
  that's not bringing any real merits.

  [Fix]

  Just dropping this part of the delta and adding the fakeroot
  dependency fixes all problems with little effort.

  [Test Case]

  Make sure that the xenial autopkgtests pass.

  [Regression Potential]

  None - really. We're only adding the fakeroot dependency that is
  installed on all the other series for the same ubuntu-image version
  already. Installing this dependency does not change anything in the
  logic of ubuntu-image - the only time it is used is for the first
  mkfs.ext4 command which always fails (due to being too old to support
  the required options).

  [Original description]

  There is a delta in xenial. We need to support missing fakeroot.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-image/+bug/1709029/+subscriptions