[Bug 1637611] Re: snappy images should not ship /etc/profile.d/Z99-cloud-locale-test.sh

[Ryan Harper]

If the cloud-init used in the build does not ship the Z99-cloud-local-
tests.sh, the hook script exits non-zero and fails the build.


https://launchpadlibrarian.net/301226697/buildlog_snap_ubuntu_xenial_amd64_core_BUILDING.txt.gz


Looking at the failed hook:

(foudres) hooks % cat 19-remove-cloud-init-locale-test.chroot 
#!/bin/sh

set -e

# bug #1637611
echo "removing /etc/profile.d/Z99-cloud-locale-test.sh"
[ -e /etc/profile.d/Z99-cloud-locale-test.sh ] && rm /etc/profile.d/Z99-cloud-locale-test.sh

(foudres) hooks % sh -x ./19-remove-cloud-init-locale-test.chroot 
+ set -e
+ echo removing /etc/profile.d/Z99-cloud-locale-test.sh
removing /etc/profile.d/Z99-cloud-locale-test.sh
+ [ -e /etc/profile.d/Z99-cloud-locale-test.sh ]
(foudres) hooks % echo $?
1


Would it be reasonable to just add an 'exit 0' in the case that the file is not-present so the build handles cloud-init with and without the profile test?

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to livecd-rootfs in Ubuntu.
https://bugs.launchpad.net/bugs/1637611

Title:
  snappy images should not ship /etc/profile.d/Z99-cloud-locale-test.sh

Status in Snappy:
  Fix Released
Status in livecd-rootfs package in Ubuntu:
  Fix Released

Bug description:
  ssh into a snappyfied beagleboardblack and you get the following
  warning:

  It's a brave new world here in Snappy Ubuntu Core! This machine
  does not use apt-get or deb packages. Please see 'snap --help'
  for app installation and transactional updates.

  _____________________________________________________________________
  WARNING! Your environment specifies an invalid locale.
   The unknown environment variables are:
     LC_CTYPE=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 LC_ALL=
   This can affect your user experience significantly, including the
   ability to manage packages. You may install the locales by running:

    sudo apt-get install locales
     sudo apt-get install language-pack-en
       or
     sudo locale-gen en_US.UTF-8

  To see all available language packs, run:
     apt-cache search "^language-pack-[a-z][a-z]$"
  To disable this message for all users, run:
     sudo touch /var/lib/cloud/instance/locale-check.skip
  _____________________________________________________________________

  
  It's funny that the first message tells us not to use apt-get and then the second one tells us to do exactly that!  Ideally of course, the locale would be automatically set up correctly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/snappy/+bug/1637611/+subscriptions