[Bug 1650596] Re: [ppc64-diag] package update for Marvell SATA HDD LEDs support

[Steve Langasek]

IBM, please confirm that the SRU test case added to the bug description
is suitable.  We will want someone with access to this Marvell hardware
to run the test case, so that we can verify that the SRU addresses the
problem.

** Description changed:

+ [SRU Justification]
+ Hardware enablement
+ 
+ [Regression potential]
+ Low; the code changes are limited to the LED detection, to enable LED support on a different class of system.
+ 
+ [Test case]
+ 1. Install ppc64-diag on an existing supported ppc64el system.
+ 2. Run 'usysident' and capture output.
+ 3. Install ppc64-diag from proposed.
+ 4. Run 'usysident' and capture output.
+ 5. Compare the output from the two runs and confirm that it is the same.
+ 6. Install ppc64-diag on a system with Marvell SATA LEDs.
+ 7. Run 'usysident' and confirm that the output includes reporting of the SATA HDD LEDs.
+ 
  == Comment: #0 - Mauricio Faria De Oliveira - 2016-12-16 05:10:23 ==
  Hi Canonical,
  
  Can you please update ppc64-diag with the patches
  to support the Marvell HDD LEDs in the 'IBM Power
  System S822LC for HPC' server?
  
  The main target is 16.04.x. I realize that SRUs
  are not suited for features, only bugs, however
  since this is related to hardware support, and
  16.04 is LTS, it seems we can ask/talk about it.
  
  The commits apply cleanly, attached debdiffs for
  Zesty and Xenial.
  
  commit id/summary
  (most-recent first; git-log style; ordered in debian/patches/series)
  
  cf718b32bcbd lpd: marvell: mark the indirect-access registers as volatile
  727c17f75033 lpd/test: Fix test case
  22e8e4edd4c2 lpd: Check for device tree property
  d88b88735bd7 lpd: Remove redundant warning message
  82a6a8c966b9 lpd: Validate get_indicator_for_loc_code() return value
  53f12274da2c lpd: opal: call all get_indices() in opal_get_indicator_list()
  d56f7f1367bd lpd: marvell: do not exit early on empty /sys/class/leds dir (OPAL)
  627287130fab lpd: marvell: handle non-unique/duplicate location codes
  efb9a4df3f88 lpd: Add support for Marvell HDD LEDs on S822LC for HPC
-  
+ 
  ---Additional Hardware Info---
  0009:04:00.0 SATA controller [0106]: Marvell Technology Group Ltd. 88SE9235 PCIe 2.0 x2 4-port SATA 6 Gb/s Controller [1b4b:9235] (rev 11) (prog-if 01 [AHCI 1.0])
- 	Subsystem: IBM 88SE9235 PCIe 2.0 x2 4-port SATA 6 Gb/s Controller [1014:0612] 
+  Subsystem: IBM 88SE9235 PCIe 2.0 x2 4-port SATA 6 Gb/s Controller [1014:0612]
  
-  
  Machine Type = IBM Power System S822LC for HPC
  
  == Comment: #5 - Mauricio Faria De Oliveira - 2016-12-16 05:18:12 ==
  @taco-screen-team
  
  For assignee suggestions, the recent uploaders of Ubuntu local versions
  were @cyphermox and @vorlon.
  
  Thanks

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ppc64-diag in Ubuntu.
https://bugs.launchpad.net/bugs/1650596

Title:
  [ppc64-diag] package update for Marvell SATA HDD LEDs support

Status in ppc64-diag package in Ubuntu:
  Triaged
Status in ppc64-diag source package in Xenial:
  Triaged
Status in ppc64-diag source package in Yakkety:
  New
Status in ppc64-diag source package in Zesty:
  Triaged

Bug description:
  [SRU Justification]
  Hardware enablement

  [Regression potential]
  Low; the code changes are limited to the LED detection, to enable LED support on a different class of system.

  [Test case]
  1. Install ppc64-diag on an existing supported ppc64el system.
  2. Run 'usysident' and capture output.
  3. Install ppc64-diag from proposed.
  4. Run 'usysident' and capture output.
  5. Compare the output from the two runs and confirm that it is the same.
  6. Install ppc64-diag on a system with Marvell SATA LEDs.
  7. Run 'usysident' and confirm that the output includes reporting of the SATA HDD LEDs.

  == Comment: #0 - Mauricio Faria De Oliveira - 2016-12-16 05:10:23 ==
  Hi Canonical,

  Can you please update ppc64-diag with the patches
  to support the Marvell HDD LEDs in the 'IBM Power
  System S822LC for HPC' server?

  The main target is 16.04.x. I realize that SRUs
  are not suited for features, only bugs, however
  since this is related to hardware support, and
  16.04 is LTS, it seems we can ask/talk about it.

  The commits apply cleanly, attached debdiffs for
  Zesty and Xenial.

  commit id/summary
  (most-recent first; git-log style; ordered in debian/patches/series)

  cf718b32bcbd lpd: marvell: mark the indirect-access registers as volatile
  727c17f75033 lpd/test: Fix test case
  22e8e4edd4c2 lpd: Check for device tree property
  d88b88735bd7 lpd: Remove redundant warning message
  82a6a8c966b9 lpd: Validate get_indicator_for_loc_code() return value
  53f12274da2c lpd: opal: call all get_indices() in opal_get_indicator_list()
  d56f7f1367bd lpd: marvell: do not exit early on empty /sys/class/leds dir (OPAL)
  627287130fab lpd: marvell: handle non-unique/duplicate location codes
  efb9a4df3f88 lpd: Add support for Marvell HDD LEDs on S822LC for HPC

  ---Additional Hardware Info---
  0009:04:00.0 SATA controller [0106]: Marvell Technology Group Ltd. 88SE9235 PCIe 2.0 x2 4-port SATA 6 Gb/s Controller [1b4b:9235] (rev 11) (prog-if 01 [AHCI 1.0])
   Subsystem: IBM 88SE9235 PCIe 2.0 x2 4-port SATA 6 Gb/s Controller [1014:0612]

  Machine Type = IBM Power System S822LC for HPC

  == Comment: #5 - Mauricio Faria De Oliveira - 2016-12-16 05:18:12 ==
  @taco-screen-team

  For assignee suggestions, the recent uploaders of Ubuntu local
  versions were @cyphermox and @vorlon.

  Thanks

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ppc64-diag/+bug/1650596/+subscriptions