[Bug 1697375] Re: whoopsie's network-manager state querying is broken

[Brian Murray]

Part 1 verified on Ubuntu 16.04:

bdmurray at clean-xenial-amd64:~$ systemctl status whoopsie
● whoopsie.service - crash report submission daemon
   Loaded: loaded (/lib/systemd/system/whoopsie.service; enabled; vendor preset: enabled)
   Active: active (running) since Fri 2017-07-21 11:33:57 PDT; 2min 32s ago
 Main PID: 1696 (whoopsie)
   CGroup: /system.slice/whoopsie.service
           └─1696 /usr/bin/whoopsie -f

Jul 21 11:33:57 clean-xenial-amd64 systemd[1]: Started crash report submission daemon.
Jul 21 11:33:57 clean-xenial-amd64 whoopsie[1696]: [11:33:57] Using lock path: /var/lock/whoopsie/lock
Jul 21 11:33:57 clean-xenial-amd64 whoopsie[1696]: [11:33:57] The default IPv4 route is: /org/freedesktop/NetworkManager/ActiveConnection/0
Jul 21 11:33:57 clean-xenial-amd64 whoopsie[1696]: [11:33:57] Not a paid data plan: /org/freedesktop/NetworkManager/ActiveConnection/0
Jul 21 11:33:57 clean-xenial-amd64 whoopsie[1696]: [11:33:57] Found usable connection: /org/freedesktop/NetworkManager/ActiveConnection/0
bdmurray at clean-xenial-amd64:~$ apt-cache policy whoopsie
whoopsie:
  Installed: 0.2.52.4
  Candidate: 0.2.52.4
  Version table:
 *** 0.2.52.4 500
        500 http://192.168.10.7/ubuntu xenial-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     0.2.52.3 500
        500 http://192.168.10.7/ubuntu xenial-updates/main amd64 Packages
     0.2.52 500
        500 http://192.168.10.7/ubuntu xenial/main amd64 Packages

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to whoopsie in Ubuntu.
https://bugs.launchpad.net/bugs/1697375

Title:
  whoopsie's network-manager state querying is broken

Status in whoopsie package in Ubuntu:
  Fix Released
Status in whoopsie source package in Xenial:
  Fix Committed
Status in whoopsie source package in Zesty:
  Fix Committed
Status in whoopsie source package in Artful:
  Fix Released

Bug description:
  [Impact]
  whoopsie's querying of network-manager's state is broken and this results in whoopsie only being able to detect if the system is on-line when network manager's state changes. Subsequently, if one manually restarts whoopsie then whoopsie will stay off-line until an n-m state change. This can result in crashes not being uploaded.  Additionally, whoopsie's systemd service file does not start after networking which is incorrect since it initially needs to query network-manager's state. (However, this ended up allowing crash reports to still be submitted because whoopsie would start first then the n-m's state would change and whoopsie would detect that.)

  [Test Case] (state detection failure)
  1) Manually restart the whoopsie service
  2) Observe the following two messages:
  "Jul 14 14:48:09 speedy whoopsie[14137]: [14:48:09] Could not get the Network Manager state:
  Jul 14 14:48:09 speedy whoopsie[14137]: [14:48:09] GDBus.Error:org.freedesktop.DBus.Error.InvalidArgs: No such property 'state'"

  with the version of network-manager from -proposed you will not see
  these messages when restarting whoopsie.

  [Test Case] (starting after network-manager0
  1) Boot your system
  2) Observe the following in syslog:
  "Jul 17 06:46:47 speedy whoopsie[1156]: [06:46:47] Could not get the Network Manager state:
  Jul 17 06:46:47 speedy whoopsie[1156]: [06:46:47] GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.NetworkManager was not provided by any .service files
  "

  with the version of network-manager in -proposed you will not see the
  "NetworkManager was not provided" messages.

  [Regression Potential]
  Its possible that systems that were not submitting crash reports suddenly will and that will use some network bandwidth and Error Tracker resources.

  - Original Description -
  ------------------------
  On artful crash reports are not uploaded automatically (several .crash files in /var/crash and no corresponding upload or .uploaded files)

  ProblemType: BugDistroRelease: Ubuntu 17.10
  Package: whoopsie 0.2.56
  ProcVersionSignature: Ubuntu 4.10.0-22.24-generic 4.10.15
  Uname: Linux 4.10.0-22-generic x86_64
  ApportVersion: 2.20.5-0ubuntu4
  Architecture: amd64
  CurrentDesktop: GNOME
  Date: Mon Jun 12 09:39:29 2017
  InstallationDate: Installed on 2013-09-03 (1377 days ago)
  InstallationMedia: Ubuntu 13.10 "Saucy Salamander" - Alpha amd64 (20130902)
  ProcEnviron:
   TERM=screen-256color
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=fr_FR.UTF-8
   SHELL=/bin/bash
  RelatedPackageVersions: apport-noui N/ASourcePackage: whoopsie
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/whoopsie/+bug/1697375/+subscriptions