[Bug 1709135] Re: add bond primary parameter

[Dimitri John Ledkov]

$ sudo netplan apply
Error in network definition //etc/netplan/bond.yaml line 13 column 8: unknown key primary

$ dpkg-query -W nplan systemd
nplan	0.23~17.04.1
systemd	232-21ubuntu5

$ sudo netplan apply
$ echo $?
0

$ dpkg-query -W systemd nplan
nplan	0.29~17.04.1
systemd	232-21ubuntu7

Bond is up, changing primary setting in netplan and executing apply,
changes the active_slave.

** Tags removed: verification-needed verification-needed-zesty
** Tags added: verification-done verification-done-zesty

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1709135

Title:
  add bond primary parameter

Status in nplan package in Ubuntu:
  Fix Released
Status in systemd package in Ubuntu:
  Fix Released
Status in nplan source package in Xenial:
  Fix Committed
Status in systemd source package in Xenial:
  Fix Committed
Status in nplan source package in Zesty:
  Fix Committed
Status in systemd source package in Zesty:
  Fix Committed
Status in nplan source package in Artful:
  Fix Released
Status in systemd source package in Artful:
  Fix Released

Bug description:
  [Impact]
  Some complex bond configurations require setting a "primary" interface for the bond, or setting this greatly improves performance on the network bond.

  [Test case]
  See below for a configuration example.
  1) Apply configuration on a system with netplan.
  2) Run 'netplan apply'
  3) Validate that netplan apply does not return with an error
  4) Validate that netplan properly sets the "primary_slave" value on the bond. This can be verified by looking at /sys/class/net/<bond interface>/bonding/primary_slave.
  5) Validate that there are no parsing errors from systemd-networkd in the journalctl

  [Regression potential]
  If existing configuration fails to be parsed, or lack of primary interface breaks configuration for existing bonds, this would be a regression caused by this update.

  ---

  ifenslave/eni support a bond parameter:  bond-primary which accepts an
  interface name that can be used to tell the kernel bonding driver
  which interface it should preferred in active-backup (and other
  modes).  This config option is missing in netplan.

   % cat bond-primary.yaml
  network:
    version: 2
    ethernets:
      eth0:
        match:
          driver: virtio
      ens4:
        match:
          driver: e1000
    bonds:
      bond0:
        parameters:
          mode: active-backup
          mii-monitor-interval: 100
          primary: e1000
        dhcp4: true

  % ./generate -r `pwd`/target
  Error in network definition /home/rharper/work/git/netplan/target//etc/netplan/bond-primary.yaml line 12 column 8: unknown key primary

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nplan/+bug/1709135/+subscriptions