[Bug 1471983] Re: USB HDD makes lshw seg-fault when run as root

[Eric Desrochers]

## VERIFICATION XENIAL ##

The lshw binary package found in xenial-proposed (Version: 02.17-1.1ubuntu3.3) works well and properly report informations of a known problematic USB 3.0 drive[1] (reported by a user):
Patriot Supersonic Rage (32GB) USB 3.0 flash drive.

and so far also work well with other USB devices that I have tested such
as a Logitech webcam[2].

[1 - lshw output - Patriot USB 3.0
...
*-usb
                   description: Mass storage device
                   product: Patriot Memory
                   physical id: 1
                   bus info: usb at 2:1
                   logical name: scsi3
                   version: 1.00
                   serial: 0701788EAE02AE03
                   capabilities: usb-3.10 scsi emulated scsi-host
                   configuration: driver=usb-storage maxpower=504mA speed=5000Mbit/s
                 *-disk
                      description: SCSI Disk
                      product: Patriot Memory
                      physical id: 0.0.0
                      bus info: scsi at 3:0.0.0
                      logical name: /dev/sda
                      version: PMAP
                      size: 29GiB (31GB)
                      capabilities: removable
                      configuration: ansiversion=6 logicalsectorsize=512 sectorsize=512
...

[2] - Logitech webcam
..
 *-usb:0
                   description: Video
                   product: HD Pro Webcam C920
                   vendor: Logitech, Inc.
                   physical id: 4
                   bus info: usb at 1:4
                   version: 0.11
                   serial: D23B587F
                   capabilities: usb-2.00
                   configuration: driver=snd-usb-audio maxpower=500mA speed=480Mbit/s
..

- Eric


** Tags removed: verification-needed-xenial
** Tags added: verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to lshw in Ubuntu.
https://bugs.launchpad.net/bugs/1471983

Title:
  USB HDD makes lshw seg-fault when run as root

Status in lshw package in Ubuntu:
  Fix Released
Status in lshw source package in Trusty:
  Fix Committed
Status in lshw source package in Vivid:
  Won't Fix
Status in lshw source package in Wily:
  Fix Released
Status in lshw source package in Xenial:
  Fix Committed
Status in lshw source package in Artful:
  Fix Released

Bug description:
  [Impact]

  Scenario #1:
  * When there is an external USB External Drive[1] connected to the system, 'lshw' command segfaults.

  Scenario #2:
  * In the Landscape context, 'lshw' is use for Landscape clients[2] HW inventory ... if an USB External Drive[1] is connected on a Trusty Landscape client, lshw will segfault, thus Landcape inventory for this computer won't be reported/updated.

  [1] - In this case :
  Patriot 32GB Supersonic Rage Series USB 3.0 Flash Drive

  [2] - landscape-client
  landscape/manager/hardwareinfo.py:    command = "/usr/bin/lshw"

  [Test Case]

  Scenario #1:
   * Install Ubuntu Trusty/14.04 LTS
   * Install lshw
     - sudo apt-get install lshw -y
   * Connect the USB 3.0 external drive to the system from where 'lshw' will be executed.
   * Execute 'lshw' or any other tools that uses 'lshw' behind the scene. (Example : Landscape computer inventory, ...)

  Scenario #2:
   * Install Ubuntu Trusty/14.04 LTS
   * Install landscape-client
   * Register the computer to the Landscape (Dedicated server or hosted)
   * Client HW inventory won't happen and system will store a 'lshw' crash file under /var/crash.

  [Regression Potential]

   * Risk is low, the upstream commit has been specifically made
  upstream to fix this problem, and the fix is part of 'lshw' Ubuntu
  package since 2015, Wily. I don't know why Trusty never been SRU'd at
  the same time, but it's never too late to fix it now that we have
  users facing this problem in Trusty/14.04 (LTS)

   * It's been ~3 years now since the patch has been first introduced in
  lshw upstream, and since then no known regression or else has been
  reporter against this specific commit.

   * Debian has the fix.

   * The code changed by this patch handles querying the serial number,
  so regression in this area may cause incorrect or missing serial
  number(s) to be reported by lshw.

  [Other Info]

   * Upstream commits :
  https://ezix.org/src/pkg/lshw/commit/d048d300b5daeb44887a7fc06ddeb120119cac8a
  https://ezix.org/src/pkg/lshw/commit/7b57987bb21d8c178c9beba1f5a574eb0af18e54

  * Bugs:
  http://www.ezix.org/project/ticket/653
  http://www.ezix.org/project/ticket/701

  [Original Description]
  The HDD enclosure causing this is the 'ORICO 2.5 inch USB 3.0'
  As seen here http://www.amazon.co.uk/dp/B00BH83LYG/

  When the enclosure is plugged in, the lshw command runs fine as a
  plain user, but when run as root with either 'sudo su', 'sudo -i' or
  just 'sudo' (I tried all to be sure), lshw starts the normal process
  of scanning through the stuff it scans, but instead of outputting any
  information, it seg-faults with the message "Segmentation Fault".

  When I unplug the HDD enclosure, lshw then runs fine as root.
  This problem occurs both with USB 3.0 and USB 2.0, and has been tested on an AMD 64-bit machine running Xubuntu 14.04 (upgraded from 12.04).

  I also tested on an older Intel 32-bit machine running Xubuntu 14.04 and got the same problem, except this time the message was different;
  "
  terminate called after throwing an instance of 'std::length_error'
    what(): basic_string::_S_create
  "

  I have pasted an extract from dmesg (from the AMD 64-bit machine) here:
  http://pastebin.com/mTfJV04k
  of which mentions lshw with some information about the USB device.

  (this is my first ever bug report, so apologies in advanced if I made any mistakes)
  (Package version lshw 02.16-2ubuntu1.2)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1471983/+subscriptions