[Bug 269429] Re: pycrypto-2.0.1 uses md5 & sha1 modules which will be deprecated in 2.6/3.0

Fri Oct 27 00:09:15 UTC 2017

Launchpad has imported 7 comments from the remote bug at
https://bugzilla.redhat.com/show_bug.cgi?id=484473.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2009-02-07T00:02:55+00:00 Henrik wrote:

Description of problem:

Applications using python-crypto may get the following warning:

/usr/lib64/python2.6/site-packages/Crypto/Hash/SHA.py:6: DeprecationWarning: the sha module is deprecated; use the hashlib module instead
  from sha import *
/usr/lib64/python2.6/site-packages/Crypto/Hash/MD5.py:6: DeprecationWarning: the md5 module is deprecated; use hashlib instead
  from md5 import *

Version-Release number of selected component (if applicable):

python-crypto-2.0.1-14.1.x86_64
python-2.6-4.fc11.x86_64

How reproducible:

Always

Steps to Reproduce:
1. 
2.
3.

Actual results:

/usr/lib64/python2.6/site-packages/Crypto/Hash/SHA.py:6: DeprecationWarning: the sha module is deprecated; use the hashlib module instead
  from sha import *
/usr/lib64/python2.6/site-packages/Crypto/Hash/MD5.py:6: DeprecationWarning: the md5 module is deprecated; use hashlib instead
  from md5 import *

Expected results:

No warnings about deprecated functions.

Additional info:

>From a quick grep it also applies to Crypto/Hash/HMAC.py

It seems the fix is simply changing as follows

From:
 from md5 import *
 import mf5
To:
 from hashlib import md5

and similar for SHA.

Reply at: https://bugs.launchpad.net/pycrypto/+bug/269429/comments/5

------------------------------------------------------------------------
On 2009-02-07T14:39:09+00:00 Stewart wrote:

Can you confirm this is fixed in 2.0.1-15? I haven't setup my rawhide VM
to test yet...

http://koji.fedoraproject.org/koji/taskinfo?taskID=1111208

Reply at: https://bugs.launchpad.net/pycrypto/+bug/269429/comments/6

------------------------------------------------------------------------
On 2009-02-07T16:33:18+00:00 Henrik wrote:

Same problem in 2.0.1-15.

Reply at: https://bugs.launchpad.net/pycrypto/+bug/269429/comments/7

------------------------------------------------------------------------
On 2009-02-07T16:36:57+00:00 Henrik wrote:

The patch in CVS looks about right, but is not added to the spec file so
not part of the build..

Needs to be both a Patch0: source line, and a %patch0 statement in %prep

Reply at: https://bugs.launchpad.net/pycrypto/+bug/269429/comments/8

------------------------------------------------------------------------
On 2009-02-07T18:07:31+00:00 Stewart wrote:

Sorry about that, fixed now. Rebuilding now:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1111411

I've also changed the patch a bit, as to remain compatible with PEP 247
we can't simply replace the md5/sha modules with their hashlib
equivalents - hashlib provides a function and not a module with the
digest_size and blocksize properties. The SHA and MD5 functions will now
contain the correct values for digest_size and blocksize (the same
values as the objects from hashlib have) as before there were hardcoded
from the Python sha and md5 modules.

Reply at: https://bugs.launchpad.net/pycrypto/+bug/269429/comments/9

------------------------------------------------------------------------
On 2009-02-12T19:10:22+00:00 Thorsten wrote:

Stewart, upstream has a report reg. this as well:

     https://bugs.launchpad.net/pycrypto/+bug/269429

There are also fixes in git:

     http://gitweb.pycrypto.org/?p=crypto/pycrypto-2.x.git;a=commitdiff;h=d2311689910240e425741a546576129f4c9735e2
     http://gitweb.pycrypto.org/?p=crypto/pycrypto-2.x.git;a=commitdiff;h=84b793416b52311643bfd456a4544444afbfb5da

Should we use those just to be on the safe side?

BTW: Steward, would you be interested to take over python-crypto? I
don#t need it anymore

Reply at: https://bugs.launchpad.net/pycrypto/+bug/269429/comments/10

------------------------------------------------------------------------
On 2009-02-18T19:25:26+00:00 Stewart wrote:

Fixed in 2.0.1-17:
http://koji.fedoraproject.org/koji/buildinfo?buildID=82882

Reply at: https://bugs.launchpad.net/pycrypto/+bug/269429/comments/11

** Changed in: python-crypto (Fedora)
   Importance: Unknown => Low

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to python-crypto in Ubuntu.
https://bugs.launchpad.net/bugs/269429

Title:
  pycrypto-2.0.1 uses md5 & sha1 modules which will be deprecated in
  2.6/3.0

Status in Bazaar:
  Fix Released
Status in Python-Crypto:
  Fix Released
Status in python-crypto package in Ubuntu:
  Fix Released
Status in python-crypto package in Fedora:
  Fix Released

Bug description:
  This is only a very minor bug (and 2.6 hasn't even been released yet),
  but since the deprecations show up for every package that uses them,
  it was quite noticeable when testing out the new versions in
  preparation.

  Unfortunately the hashlib module isn't PEP 247 compliant, so there
  will be a bit work to maintain the current interface.  It might be
  worth filing a bug at python.org suggesting that deprecating module
  compliant to a PEP for one that isn't should be fixed (preferably by
  providing a compliant interface).

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr/+bug/269429/+subscriptions