[Bug 502076] Re: bzr-handle-patch doesn't like patch files containing "diff" lines before each patch
Bug Watch Updater
502076 at bugs.launchpad.net
Fri Oct 27 06:01:09 UTC 2017
Launchpad has imported 13 comments from the remote bug at
https://bugzilla.redhat.com/show_bug.cgi?id=557573.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.
------------------------------------------------------------------------
On 2010-01-21T20:50:38+00:00 Felix wrote:
abrt 1.0.3 detected a crash.
How to reproduce: Try to open the patch file from https://mozilla-plugin.forge.funambol.org/servlets/TrackerDownload/remcurreport/true/template/ViewAttachment.vm/attachid/453/filename/0001-fix-preferences.patch and you will get the attached crash.
Attached file: backtrace
cmdline: /usr/bin/python /usr/bin/bzr-handle-patch /home/fm/0001-fix-preferences.patch
component: bzr-gtk
executable: /usr/bin/bzr-handle-patch
kernel: 2.6.31.9-174.fc12.i686.PAE
package: bzr-gtk-0.97.0-2.fc12
uuid: 4b0c976f
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/1
------------------------------------------------------------------------
On 2010-01-21T20:50:41+00:00 Felix wrote:
Created attachment 386005
File: backtrace
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/2
------------------------------------------------------------------------
On 2010-01-22T04:25:45+00:00 Toshio wrote:
This has been filed upstream before. Putting upstream bug# in.
However, this looks like a bug in bzr code rather than bzr-gtk. Looking
further.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/3
------------------------------------------------------------------------
On 2010-01-22T11:12:03+00:00 Toshio wrote:
I'm able to fix this bug with a patch to bzr's patch handling to make it
more lenient. (Currently, that patch handling code doesn't accept
"junk" before and after the individual patches within a file.). Will
attach a patch.
hno, do you know if the patches.py code is meant to handle any patch
file? If so, this is appropriate. If it's really only meant to handle
bzr-generated patches, then bzr-gtk is misusing the bzrlib code.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/6
------------------------------------------------------------------------
On 2010-01-22T11:12:50+00:00 Toshio wrote:
Created attachment 386120
Patch to make bzr's patch handling more lenient
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/7
------------------------------------------------------------------------
On 2010-02-08T16:55:34+00:00 Toshio wrote:
*** Bug 562567 has been marked as a duplicate of this bug. ***
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/12
------------------------------------------------------------------------
On 2010-03-16T20:24:26+00:00 Damian wrote:
How to reproduce
-----
1. open the following url in firefox:
http://www.splitted-desktop.com/~gbeauchesne/libva/patches/
2. click on the link 033_g45_add_rgba_subpic.patch
3. open the file with Baazar (crash is reproducible in 100%)
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/14
------------------------------------------------------------------------
On 2010-04-13T13:18:48+00:00 Toshio wrote:
My patch to bzr to fix this is in bzr-2.2b1. We could safely backport
it to current bzr packages. Also need a patch to bzr-gtk to turn this
functionality on. I have a patch for that linked to the upstream bug
report but upstream needs it cconditionalized on having a new enough
bzr.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/16
------------------------------------------------------------------------
On 2010-04-13T17:09:22+00:00 Toshio wrote:
New fix for bzr-gtk submitted upstream:
https://code.launchpad.net/~toshio/bzr-gtk/handle-patch-
dirty/+merge/23330
If accepted, we'll likely want to backport both the bzr and bzr-gtk
fixes back to F-12 and F-13.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/18
------------------------------------------------------------------------
On 2010-07-30T19:37:22+00:00 Damian wrote:
Package: bzr-gtk-0.97.0-4.fc12
Architecture: i686
OS Release: Fedora release 12 (Constantine)
How to reproduce
-----
1. Add patch as an attachment in the thunderbird program
2. Double click the patch to see its content
3.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/19
------------------------------------------------------------------------
On 2010-10-11T18:18:21+00:00 Damian wrote:
Package: bzr-gtk-0.98.0-1.fc13
Architecture: i686
OS Release: Fedora release 13 (Goddard)
Comment
-----
Just tried to open a C source file.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/21
------------------------------------------------------------------------
On 2010-11-04T00:18:18+00:00 Bug wrote:
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora
'version' of '12'.
Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version prior to Fedora 12's end of life.
Bug Reporter: Thank you for reporting this issue and we are sorry that
we may not be able to fix it before Fedora 12 is end of life. If you
would still like to see this bug fixed and are able to reproduce it
against a later version of Fedora please change the 'version' of this
bug to the applicable version. If you are unable to change the version,
please add a comment here and someone will do it for you.
Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
The process we are following is described here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/22
------------------------------------------------------------------------
On 2010-12-04T00:01:46+00:00 Bug wrote:
Fedora 12 changed to end-of-life (EOL) status on 2010-12-02. Fedora 12 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.
If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version.
Thank you for reporting this bug and we are sorry it could not be fixed.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/502076/comments/23
** Changed in: bzr (Fedora)
Status: Unknown => Won't Fix
** Changed in: bzr (Fedora)
Importance: Unknown => Medium
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to bzr in Ubuntu.
https://bugs.launchpad.net/bugs/502076
Title:
bzr-handle-patch doesn't like patch files containing "diff" lines
before each patch
Status in Bazaar:
Fix Released
Status in Bazaar GTK+ Frontends:
Fix Released
Status in bzr package in Ubuntu:
Fix Released
Status in bzr package in Fedora:
Won't Fix
Bug description:
Binary package hint: bzr-gtk
As bzr-handle-patch registers itself for .patch files, Firefox offers
to use it when I click on a .patch as can be found on the Debian PTS
(links to the patches on http://patches.ubuntu.com). As I regularly
use these patches to check all current Ubuntu delta when sponsoring
merges, bzr-handle-patch isn't really helpful (as the standard
application) as it claims broken patch files and crashes:
Malformed patch header. No orig name
'diff -pruN 1.2.4-1/debian/changelog 1.2.4-1ubuntu1/debian/changelog\n'
The patch itself looks as following:
diff -pruN 1.2.4-1/debian/changelog 1.2.4-1ubuntu1/debian/changelog
--- 1.2.4-1/debian/changelog 2009-06-25 21:20:52.000000000 +0100
+++ 1.2.4-1ubuntu1/debian/changelog 2009-06-25 21:15:43.000000000 +0100
@@ -1,3 +1,11 @@
[...]
If I remove the offending "diff" lines from the whole patch, bzr-handle-patch can open it then.
As creating patch files with "diff -ruN" (or even "diff -pruN") is pretty common, bzr-handle-patch should cope with them (if it registers itself for those files).
To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr/+bug/502076/+subscriptions
More information about the foundations-bugs
mailing list