[Bug 582347] Re: etags screw filenames starting with ./

Fri Oct 27 08:15:09 UTC 2017

Launchpad has imported 9 comments from the remote bug at
https://bugzilla.redhat.com/show_bug.cgi?id=545398.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2009-12-08T13:26:05+00:00 Sjoerd wrote:

Created attachment 376898
Patch for the problem described, replacing strcpy with memmove.

Description of problem:
This is a bug against etags.emacs which is packaged in emacs-common, but there is no separate component called emacs-common.  This same bug exists in etags.xemacs, packaged in xemacs-common.

When etags is run with filenames starting with "./", it normalizes them
to start without "./", but does so incorrectly, messing up the result.

Version-Release number of selected component (if applicable):
emacs-common-23.1-13.fc12.x86_64
xemacs-common-21.5.29-8.fc12.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create a file with a C function and path e.g. src/gdk/gdk_atoms.c
2. Run /usr/bin/etags.emacs ./src/gdk/gdk_atoms.c
3. Observe the filename in TAGS

Actual results:
The filename recorded in the TAGS file is src/gdk/gdk_otoms.c (note "o" after underscore).

Expected results:
The filename should be src/gdk/gdk_atoms.c

Additional info:
The problem is a call to strcpy on overlapping buffers.  In Fedora 11 and before that seems to have worked, but in Fedora 12 it often does not work, at least not for slightly longer filenames.

The attached patch should also work for etags.xemacs in xemacs-common,
except for differing line numbers.

Reply at: https://bugs.launchpad.net/ubuntu/+source/exuberant-
ctags/+bug/582347/comments/0

------------------------------------------------------------------------
On 2009-12-08T13:31:25+00:00 Sjoerd wrote:

Also see bug 545399 for the XEmacs version of the bug.

Reply at: https://bugs.launchpad.net/ubuntu/+source/exuberant-
ctags/+bug/582347/comments/1

------------------------------------------------------------------------
On 2009-12-08T16:52:30+00:00 Karel wrote:

I cannot reproduce it on 32-bit Fedora, but the usage of strcpy in the
code is clearly wrong. Moreover, this bug is already fixed in the
upstream CVS.

Reply at: https://bugs.launchpad.net/ubuntu/+source/exuberant-
ctags/+bug/582347/comments/2

------------------------------------------------------------------------
On 2009-12-08T17:29:57+00:00 Karel wrote:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1863033

The fix will be a part of next update.

Thanks for nicely detailed bug report.

Reply at: https://bugs.launchpad.net/ubuntu/+source/exuberant-
ctags/+bug/582347/comments/3

------------------------------------------------------------------------
On 2010-03-30T23:18:05+00:00 Fedora wrote:

emacs-23.1-11.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/emacs-23.1-11.fc11

Reply at: https://bugs.launchpad.net/ubuntu/+source/exuberant-
ctags/+bug/582347/comments/4

------------------------------------------------------------------------
On 2010-04-01T01:41:57+00:00 Fedora wrote:

emacs-23.1-11.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update emacs'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/emacs-23.1-11.fc11

Reply at: https://bugs.launchpad.net/ubuntu/+source/exuberant-
ctags/+bug/582347/comments/5

------------------------------------------------------------------------
On 2010-04-01T16:10:06+00:00 Fedora wrote:

emacs-23.1-13.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/emacs-23.1-13.fc11

Reply at: https://bugs.launchpad.net/ubuntu/+source/exuberant-
ctags/+bug/582347/comments/6

------------------------------------------------------------------------
On 2010-04-09T01:45:18+00:00 Fedora wrote:

emacs-23.1-13.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update emacs'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/emacs-23.1-13.fc11

Reply at: https://bugs.launchpad.net/ubuntu/+source/exuberant-
ctags/+bug/582347/comments/7

------------------------------------------------------------------------
On 2010-04-20T13:08:50+00:00 Fedora wrote:

emacs-23.1-13.fc11 has been pushed to the Fedora 11 stable repository.
If problems still persist, please make note of it in this bug report.

Reply at: https://bugs.launchpad.net/ubuntu/+source/exuberant-
ctags/+bug/582347/comments/8

** Changed in: emacs23 (Fedora)
       Status: Unknown => Fix Released

** Changed in: emacs23 (Fedora)
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to exuberant-ctags in Ubuntu.
https://bugs.launchpad.net/bugs/582347

Title:
  etags screw filenames starting with ./

Status in emacs23 package in Ubuntu:
  Confirmed
Status in exuberant-ctags package in Ubuntu:
  Fix Released
Status in exuberant-ctags package in Debian:
  Fix Released
Status in emacs23 package in Fedora:
  Fix Released

Bug description:
  Binary package hint: exuberant-ctags

  when running etags using following form:
  find . -name '*.[hc]' | xargs etags -a
  The generated TAGS file contains wrong file names.
  The same problem exists with etags problem coming from emacs23 package
  Works correctly with :
  find ../<upperdir>/. -name  '*.[hc]' | xargs etags -a

  The same problem reported here:
  https://bugzilla.redhat.com/show_bug.cgi?id=545398

  ProblemType: Bug
  DistroRelease: Ubuntu 10.04
  Package: exuberant-ctags 1:5.8-2
  ProcVersionSignature: Ubuntu 2.6.32-22.33-generic 2.6.32.11+drm33.2
  Uname: Linux 2.6.32-22-generic x86_64
  NonfreeKernelModules: fglrx
  Architecture: amd64
  Date: Tue May 18 18:19:43 2010
  InstallationMedia: Kubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100427)
  ProcEnviron:
   LANGUAGE=
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: exuberant-ctags

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/emacs23/+bug/582347/+subscriptions