[Bug 997391] Re: Symbolic links can create recursive loop that causes Baobab to never finish scanning

[Bug Watch Updater]

Launchpad has imported 4 comments from the remote bug at
https://bugzilla.redhat.com/show_bug.cgi?id=811399.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2012-04-10T21:58:28+00:00 Simon wrote:

Description of problem:
when i let baobab scan a windows 7 partition it keeps getting into infinite loops because of some symlinks.

Version-Release number of selected component (if applicable):
3.4.0

How reproducible:
always

Steps to Reproduce:
1. let baobab scan an ntfs partition with this special kind of symlink
2.
3.
  
Actual results:
baobab follows the symlink

Expected results:
baobab skips the symlink

Additional info:
there is something special about this kind of symlinks,
stat reports that it is a symlink, but that it has 2 links, which is the only difference I see from the normal symlinks

Reply at:
https://bugs.launchpad.net/fedora/+source/baobab/+bug/997391/comments/0

------------------------------------------------------------------------
On 2012-08-18T13:00:49+00:00 Erik wrote:

This bug is caused by a bug in the ntfs-3g package.

A bugreport was filed upstream and they've already proposed a patch
which resolves this issue:
http://tuxera.com/forum/viewtopic.php?f=2&t=29578

I just filed a ticket to the ntfs-3g maintainer in Fedora asking to
apply this patch in the Fedora ntfs-3g package: bug 849332

Reply at:
https://bugs.launchpad.net/fedora/+source/baobab/+bug/997391/comments/3

------------------------------------------------------------------------
On 2012-08-24T18:45:50+00:00 Fedora wrote:

ntfs-3g-2012.1.15-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/FEDORA-2012-12279/ntfs-3g-2012.1.15-3.fc17

Reply at:
https://bugs.launchpad.net/fedora/+source/baobab/+bug/997391/comments/7

------------------------------------------------------------------------
On 2012-09-04T22:57:03+00:00 Fedora wrote:

ntfs-3g-2012.1.15-3.fc17 has been pushed to the Fedora 17 stable
repository.  If problems still persist, please make note of it in this
bug report.

Reply at:
https://bugs.launchpad.net/fedora/+source/baobab/+bug/997391/comments/9


** Changed in: baobab (Fedora)
       Status: Unknown => Fix Released

** Changed in: baobab (Fedora)
   Importance: Unknown => Undecided

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ntfs-3g in Ubuntu.
https://bugs.launchpad.net/bugs/997391

Title:
  Symbolic links can create recursive loop that causes Baobab to never
  finish scanning

Status in ntfs-3g package in Ubuntu:
  Fix Released
Status in ntfs-3g source package in Precise:
  Fix Released
Status in ntfs-3g package in Debian:
  Fix Released
Status in baobab package in Fedora:
  Fix Released
Status in ntfs-3g package in Fedora:
  Unknown

Bug description:
  = Stable Release Update discussion =
  == Impact ==
  readdir() returns the directory type for junction points (NTFS symbolic links). This causes baobab to go into an endless loop when scanning an NTFS file-system. Older baobabs used stat() which correctly identified junction points as being symlinks.

  This would affect all users who run baobab on a Windows 7 (or later)
  root file-system. For dual-booting users, that's fairly likely to be
  where they store most of their media (it's accessible from both OSs),
  and thus the file-system most likely to be full and need the help of
  baobab.

  == Test Case ==
  * Mount a Windows 7 root filesystem.
  * Run baobab on Users/somebody/Local\ Settings/Application\ Data (or just the whole file-system).
  * If affected by this bug, it will appear to take forever to scan, and under strace it's obvious that it's following an endless loop of symlinks. 

  == Regression potential ==
  The patch is limited to readdir() and simply adds support for more types of file. It is not trivial, but is readable and seems plausible.

  Fedora appear are also backporting this patch to F17.

  = Original report =
  1) The release of Ubuntu you are using, via 'lsb_release -rd' or System -> About Ubuntu
  Ubuntu 12.04 LTS

  2) The version of the package you are using, via 'apt-cache policy pkgname' or by checking in Software Center
  3.4.1-0ubuntu1

  3) What you expected to happen
  Detect the presence of symbolic link and omit directories under the link

  4) What happened instead
  Scans directories under the symbolic link, which is in reference to the directory above the symbolic link, and continue scanning without completion.

  Case in which bug was discovered:
  When scanning an NTFS drive with Windows 7 installed, the Users\System\AppData\Local\ directory contains a symlink called "Application Data" back to the Users\System\AppData\Local\ directory. This is used to maintain legacy support for older programs that require the Application Data folder. However, when Baobab reaches this point, it assumes that this continues to an infinite depth, and never completes the scan.

  Workaround:
  Omit scanning of the directory that is known to contain such links.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ntfs-3g/+bug/997391/+subscriptions