[Bug 1703604] Re: samba's apport hook uses incorrect syntax to list cifs mounts

[Andreas Hasenack]

** Changed in: samba (Ubuntu)
     Assignee: (unassigned) => Andreas Hasenack (ahasenack)

** Changed in: samba (Ubuntu)
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to samba in Ubuntu.
https://bugs.launchpad.net/bugs/1703604

Title:
  samba's apport hook uses incorrect syntax to list cifs mounts

Status in samba package in Ubuntu:
  In Progress

Bug description:
  The current apport hook in debian/source_samba.py uses
  command_output() incorrectly to list cifs shares:

  report['CIFSMounts'] = command_output(['mount', '|', 'grep', 'cifs'])

  
  command_output() from apport.hookutils doesn't use shell or system(), so the above is just passing a literal "|" to mount as a parameter, which fails:

  Error: command ['mount', '|', 'grep', 'cifs'] failed with exit code 1:

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1703604/+subscriptions