[Bug 1718497] [NEW] checkFreeSpace says it checks /var but may not really

[Brian Murray]

Public bug reported:

The function checkFreeSpace in DistUpgrade/DistUpgradeCache.py says, in
the docstring, that it checks "free space on /var" but then there is no
required size given so I'm pretty sure /var is not checked for free
space.  Here's the check for free space:

1169         # sum up space requirements
1170         for (dir, size) in [(archivedir, self.required_download),
1171                             # plus 50M safety buffer in /usr
1172                             ("/usr", self.additional_required_space),
1173                             ("/usr", 50*1024*1024),
1174                             ("/boot", space_in_boot),
1175                             ("/tmp", 5*1024*1024),   # /tmp for dkms LP: #427035
1176                             ("/", 10*1024*1024),     # small safety buffer /
1177                             (aufs_rw_dir, required_for_aufs),
1178                             # if snapshots are in use
1179                             ("/usr", required_for_snapshots),
1180                            ]:
1181             dir = os.path.realpath(dir)
1182             logging.debug("dir '%s' needs '%s' of '%s' (%f)" % (dir, size, fs_free[dir], fs_free[dir].free))
1183             fs_free[dir].free -= size
1184             fs_free[dir].need += size
1185 
1186         # check for space required violations
1187         required_list = {}
1188         for dir in fs_free:

It's possible that checking /var is unnecessary since we check
"archivedir" which is:

archivedir = apt_pkg.config.find_dir("Dir::Cache::archives")

** Affects: ubuntu-release-upgrader (Ubuntu)
     Importance: Medium
         Status: New


** Tags: artful rls-bb-incoming

** Changed in: ubuntu-release-upgrader (Ubuntu)
   Importance: Undecided => Medium

** Tags added: artful rls-bb-incoming

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1718497

Title:
  checkFreeSpace says it checks /var but may not really

Status in ubuntu-release-upgrader package in Ubuntu:
  New

Bug description:
  The function checkFreeSpace in DistUpgrade/DistUpgradeCache.py says,
  in the docstring, that it checks "free space on /var" but then there
  is no required size given so I'm pretty sure /var is not checked for
  free space.  Here's the check for free space:

  1169         # sum up space requirements
  1170         for (dir, size) in [(archivedir, self.required_download),
  1171                             # plus 50M safety buffer in /usr
  1172                             ("/usr", self.additional_required_space),
  1173                             ("/usr", 50*1024*1024),
  1174                             ("/boot", space_in_boot),
  1175                             ("/tmp", 5*1024*1024),   # /tmp for dkms LP: #427035
  1176                             ("/", 10*1024*1024),     # small safety buffer /
  1177                             (aufs_rw_dir, required_for_aufs),
  1178                             # if snapshots are in use
  1179                             ("/usr", required_for_snapshots),
  1180                            ]:
  1181             dir = os.path.realpath(dir)
  1182             logging.debug("dir '%s' needs '%s' of '%s' (%f)" % (dir, size, fs_free[dir], fs_free[dir].free))
  1183             fs_free[dir].free -= size
  1184             fs_free[dir].need += size
  1185 
  1186         # check for space required violations
  1187         required_list = {}
  1188         for dir in fs_free:

  It's possible that checking /var is unnecessary since we check
  "archivedir" which is:

  archivedir = apt_pkg.config.find_dir("Dir::Cache::archives")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1718497/+subscriptions