[Bug 1765851] [NEW] dh_compress doesn't handle already compressed manpages with .so links

[Andreas Hasenack]

Public bug reported:

debhelper 11.1.6ubuntu1 from bionic

I'm preparing pmdk packages (upstream: https://github.com/pmem/pmdk) in
my git repo
(https://code.launchpad.net/~ahasenack/ubuntu/+source/pmdk/+git/pmdk/+ref
/rename-pmdk-1.4) and noticed that dh_compress is adding another .gz
suffix to manpages that are already compressed if they have just ".so"
macros inside pointing elsewhere.

Attached is a full build log with DH_VERBOSE set.

Here is the gist of it: https://pastebin.ubuntu.com/p/TmyKycSkGK/

rm -f debian/libpmemlog-dev/usr/share/man/man3/pmemlog_open.3.gz debian/libpmemlog-dev/usr/share/man/man3/pmemlog_open.3.gz.gz
ln -s pmemlog_create.3.gz debian/libpmemlog-dev/usr/share/man/man3/pmemlog_open.3.gz.gz

Upstream already produces compressed manpages. Using pmemlog_open as an example again:
(rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ rm -rf /tmp/pmdk
(rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ mkdir /tmp/pmdk
(rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ make DESTDIR=/tmp/pmdk install
(...)

(rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ find /tmp/pmdk/ -name pmemlog_open.3* -ls -o -name pmemlog_create.3* -ls
   115952      1 -rw-r--r--   1 ubuntu   ubuntu         56 Apr 20 21:09 /tmp/pmdk/usr/local/share/man/man3/pmemlog_open.3.gz
   115890      5 -rw-r--r--   1 ubuntu   ubuntu       2931 Apr 20 21:09 /tmp/pmdk/usr/local/share/man/man3/pmemlog_create.3.gz
(rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ zcat /tmp/pmdk/usr/local/share/man/man3/pmemlog_open.3.gz
.so pmemlog_create.3
(rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ 


The double gzipped symlinks end up in the debs like this:
ubuntu at bionic-pmdk:~/pmdk$ for n in lib*.deb; do dpkg --contents $n|grep -E '\.gz\.gz'; done
lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_check_version.3.gz.gz -> ../man7/libpmem.7.gz
lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_deep_drain.3.gz.gz -> pmem_flush.3.gz
lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_deep_flush.3.gz.gz -> pmem_flush.3.gz
lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_deep_persist.3.gz.gz -> pmem_flush.3.gz
lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_drain.3.gz.gz -> pmem_flush.3.gz
lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_errormsg.3.gz.gz -> ../man7/libpmem.7.gz
(...)

** Affects: debhelper (Ubuntu)
     Importance: Undecided
         Status: New

** Summary changed:

- dh_compress doesn't handle already compressed manpages
+ dh_compress doesn't handle already compressed manpages with .so links

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to debhelper in Ubuntu.
https://bugs.launchpad.net/bugs/1765851

Title:
  dh_compress doesn't handle already compressed manpages with .so links

Status in debhelper package in Ubuntu:
  New

Bug description:
  debhelper 11.1.6ubuntu1 from bionic

  I'm preparing pmdk packages (upstream: https://github.com/pmem/pmdk)
  in my git repo
  (https://code.launchpad.net/~ahasenack/ubuntu/+source/pmdk/+git/pmdk/+ref
  /rename-pmdk-1.4) and noticed that dh_compress is adding another .gz
  suffix to manpages that are already compressed if they have just ".so"
  macros inside pointing elsewhere.

  Attached is a full build log with DH_VERBOSE set.

  Here is the gist of it: https://pastebin.ubuntu.com/p/TmyKycSkGK/

  rm -f debian/libpmemlog-dev/usr/share/man/man3/pmemlog_open.3.gz debian/libpmemlog-dev/usr/share/man/man3/pmemlog_open.3.gz.gz
  ln -s pmemlog_create.3.gz debian/libpmemlog-dev/usr/share/man/man3/pmemlog_open.3.gz.gz

  Upstream already produces compressed manpages. Using pmemlog_open as an example again:
  (rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ rm -rf /tmp/pmdk
  (rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ mkdir /tmp/pmdk
  (rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ make DESTDIR=/tmp/pmdk install
  (...)

  (rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ find /tmp/pmdk/ -name pmemlog_open.3* -ls -o -name pmemlog_create.3* -ls
     115952      1 -rw-r--r--   1 ubuntu   ubuntu         56 Apr 20 21:09 /tmp/pmdk/usr/local/share/man/man3/pmemlog_open.3.gz
     115890      5 -rw-r--r--   1 ubuntu   ubuntu       2931 Apr 20 21:09 /tmp/pmdk/usr/local/share/man/man3/pmemlog_create.3.gz
  (rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ zcat /tmp/pmdk/usr/local/share/man/man3/pmemlog_open.3.gz
  .so pmemlog_create.3
  (rename-pmdk-1.4)ubuntu at bionic-pmdk:~/pmdk/pmdk-git$ 

  
  The double gzipped symlinks end up in the debs like this:
  ubuntu at bionic-pmdk:~/pmdk$ for n in lib*.deb; do dpkg --contents $n|grep -E '\.gz\.gz'; done
  lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_check_version.3.gz.gz -> ../man7/libpmem.7.gz
  lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_deep_drain.3.gz.gz -> pmem_flush.3.gz
  lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_deep_flush.3.gz.gz -> pmem_flush.3.gz
  lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_deep_persist.3.gz.gz -> pmem_flush.3.gz
  lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_drain.3.gz.gz -> pmem_flush.3.gz
  lrwxrwxrwx root/root         0 2018-04-17 20:57 ./usr/share/man/man3/pmem_errormsg.3.gz.gz -> ../man7/libpmem.7.gz
  (...)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debhelper/+bug/1765851/+subscriptions