[Bug 1583324] Re: Samba won't start when an include statement in smb.conf has a variable substitution

[Andreas Hasenack]

** Description changed:

+ [Impact]
+ 
+  * An explanation of the effects of the bug on users and
+ 
+  * justification for backporting the fix to the stable release.
+ 
+  * In addition, it is helpful, but not required, to include an
+    explanation of how the upload fixes this bug.
+ 
+ [Test Case]
+ 
+  * detailed instructions how to reproduce the bug
+ 
+  * these should allow someone who is not familiar with the affected
+    package to reproduce the bug and verify that the updated package fixes
+    the problem.
+ 
+ [Regression Potential]
+ 
+  * discussion of how regressions are most likely to manifest as a result
+ of this change.
+ 
+  * It is assumed that any SRU candidate patch is well-tested before
+    upload and has a low overall risk of regression, but it's important
+    to make the effort to think about what ''could'' happen in the
+    event of a regression.
+ 
+  * This both shows the SRU team that the risks have been considered,
+    and provides guidance to testers in regression-testing the SRU.
+ 
+ [Other Info]
+  
+  * Anything else you think is useful to include
+  * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board
+  * and address these questions in advance
+ 
+ 
+ 
+ [Original Description]
+ 
  Samba refuses to start when the smb.conf file contains an include line
  with a variable substitution like "include = /etc/samba/smb.conf.%U"
  
  According to the man page for smb.conf, all but a few specific variable
  substitutions should work.
  
  include (G)
  
-            This allows you to include one config file inside another.
+            This allows you to include one config file inside another.
  The file is included literally, as though typed in place.
  
-            It takes the standard substitutions, except %u, %P and %S.
+            It takes the standard substitutions, except %u, %P and %S.
  
-            The parameter include = registry has a special meaning: It does not include a file named registry from the current working directory, but
-            instead reads the global configuration options from the registry. See the section on registry-based configuration for details. Note that
-            this option automatically activates registry shares.
+            The parameter include = registry has a special meaning: It does not include a file named registry from the current working directory, but
+            instead reads the global configuration options from the registry. See the section on registry-based configuration for details. Note that
+            this option automatically activates registry shares.
  
-            Default: include =
+            Default: include =
  
-            Example: include = /usr/local/samba/lib/admin_smb.conf
- 
+            Example: include = /usr/local/samba/lib/admin_smb.conf
  
  It is probably related to this bug in samba:
  https://bugzilla.samba.org/show_bug.cgi?id=10722
  
  Description:    Ubuntu 16.04 LTS
  Release:        16.04
  
  samba:
-   Installed: 2:4.3.9+dfsg-0ubuntu0.16.04.1
-   Candidate: 2:4.3.9+dfsg-0ubuntu0.16.04.1
-   Version table:
-  *** 2:4.3.9+dfsg-0ubuntu0.16.04.1 500
-         500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
-         500 http://security.ubuntu.com/ubuntu xenial-security/main amd64 Packages
-         100 /var/lib/dpkg/status
-      2:4.3.8+dfsg-0ubuntu1 500
-         500 http://us.archive.ubuntu.com/ubuntu xenial/main amd64 Packages
+   Installed: 2:4.3.9+dfsg-0ubuntu0.16.04.1
+   Candidate: 2:4.3.9+dfsg-0ubuntu0.16.04.1
+   Version table:
+  *** 2:4.3.9+dfsg-0ubuntu0.16.04.1 500
+         500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
+         500 http://security.ubuntu.com/ubuntu xenial-security/main amd64 Packages
+         100 /var/lib/dpkg/status
+      2:4.3.8+dfsg-0ubuntu1 500
+         500 http://us.archive.ubuntu.com/ubuntu xenial/main amd64 Packages

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to samba in Ubuntu.
https://bugs.launchpad.net/bugs/1583324

Title:
  Samba won't start when an include statement in smb.conf has a variable
  substitution

Status in samba package in Ubuntu:
  Fix Released
Status in samba source package in Trusty:
  In Progress
Status in samba source package in Xenial:
  In Progress

Bug description:
  [Impact]

   * An explanation of the effects of the bug on users and

   * justification for backporting the fix to the stable release.

   * In addition, it is helpful, but not required, to include an
     explanation of how the upload fixes this bug.

  [Test Case]

   * detailed instructions how to reproduce the bug

   * these should allow someone who is not familiar with the affected
     package to reproduce the bug and verify that the updated package fixes
     the problem.

  [Regression Potential]

   * discussion of how regressions are most likely to manifest as a
  result of this change.

   * It is assumed that any SRU candidate patch is well-tested before
     upload and has a low overall risk of regression, but it's important
     to make the effort to think about what ''could'' happen in the
     event of a regression.

   * This both shows the SRU team that the risks have been considered,
     and provides guidance to testers in regression-testing the SRU.

  [Other Info]
   
   * Anything else you think is useful to include
   * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board
   * and address these questions in advance


  
  [Original Description]

  Samba refuses to start when the smb.conf file contains an include line
  with a variable substitution like "include = /etc/samba/smb.conf.%U"

  According to the man page for smb.conf, all but a few specific
  variable substitutions should work.

  include (G)

             This allows you to include one config file inside another.
  The file is included literally, as though typed in place.

             It takes the standard substitutions, except %u, %P and %S.

             The parameter include = registry has a special meaning: It does not include a file named registry from the current working directory, but
             instead reads the global configuration options from the registry. See the section on registry-based configuration for details. Note that
             this option automatically activates registry shares.

             Default: include =

             Example: include = /usr/local/samba/lib/admin_smb.conf

  It is probably related to this bug in samba:
  https://bugzilla.samba.org/show_bug.cgi?id=10722

  Description:    Ubuntu 16.04 LTS
  Release:        16.04

  samba:
    Installed: 2:4.3.9+dfsg-0ubuntu0.16.04.1
    Candidate: 2:4.3.9+dfsg-0ubuntu0.16.04.1
    Version table:
   *** 2:4.3.9+dfsg-0ubuntu0.16.04.1 500
          500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
          500 http://security.ubuntu.com/ubuntu xenial-security/main amd64 Packages
          100 /var/lib/dpkg/status
       2:4.3.8+dfsg-0ubuntu1 500
          500 http://us.archive.ubuntu.com/ubuntu xenial/main amd64 Packages

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1583324/+subscriptions