[Bug 1806463] [NEW] Unattended-Upgrade::InstallOnShutdown "true" not working

[Justin V]

Public bug reported:

Cosmic, unattended-upgrades 1.5ubuntu3.18.10.0

Trying to get install-on-shutdown working.  Added << Unattended-
Upgrade::InstallOnShutdown "true"; >> to apt.conf.

It appears that the logic for install-on-shutdown is in /usr/share
/unattended-upgrades/unattended-upgrade-shutdown.  The logic for run-on-
shutdown is in UnattendedUpgradesShutdown.try_iter_on_shutdown, which is
only called by iter "if not self.stop_signal_received.is_set()".
However, since --wait-for-signal is true, it waits for a signal, then
the iter says "signal recieved, so skip upgrade":

1. apt.conf: Unattended-Upgrade::InstallOnShutdown "true" (though, unused)
2. unattended-upgrades.service: .../unattended-upgrade-shutdown --wait-for-signal
3. UnattendedUpgradesShutdown.run: signal_handler is installed; wait.
4. UUS.run.signal_handler: stop_signal_received.set(); start_iterations()
5. UUS.start_iterations: scheduler timer to call self.iter
6. UUS.iter: not self.stop_signal_received.is_set() is always False
7. UUS.try_iter_on_shutdown is never called

** Affects: unattended-upgrades (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unattended-upgrades in Ubuntu.
https://bugs.launchpad.net/bugs/1806463

Title:
  Unattended-Upgrade::InstallOnShutdown "true" not working

Status in unattended-upgrades package in Ubuntu:
  New

Bug description:
  Cosmic, unattended-upgrades 1.5ubuntu3.18.10.0

  Trying to get install-on-shutdown working.  Added << Unattended-
  Upgrade::InstallOnShutdown "true"; >> to apt.conf.

  It appears that the logic for install-on-shutdown is in /usr/share
  /unattended-upgrades/unattended-upgrade-shutdown.  The logic for run-
  on-shutdown is in UnattendedUpgradesShutdown.try_iter_on_shutdown,
  which is only called by iter "if not
  self.stop_signal_received.is_set()".  However, since --wait-for-signal
  is true, it waits for a signal, then the iter says "signal recieved,
  so skip upgrade":

  1. apt.conf: Unattended-Upgrade::InstallOnShutdown "true" (though, unused)
  2. unattended-upgrades.service: .../unattended-upgrade-shutdown --wait-for-signal
  3. UnattendedUpgradesShutdown.run: signal_handler is installed; wait.
  4. UUS.run.signal_handler: stop_signal_received.set(); start_iterations()
  5. UUS.start_iterations: scheduler timer to call self.iter
  6. UUS.iter: not self.stop_signal_received.is_set() is always False
  7. UUS.try_iter_on_shutdown is never called

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1806463/+subscriptions