[Bug 1797209] Re: do-release-upgrade should block release upgrades in some circumstances

[Brian Murray]

On Sat, Dec 15, 2018 at 01:04:54PM -0000, Tom Womack wrote:
> I am not happy with the state of this in 16.04: I do 'sudo do-release-
> upgrade' in the anticipation of getting 18.04.1, and I get instead
> 
> 'Checking for a new Ubuntu release
> Please install all available updates for your release before upgrading.'
> 
> even if I have just run sudo apt-get update; sudo apt-get upgrade.
> 
> I am *not* in the habit of rebooting my machine after updates:
> 
> oak at oak:~$ uptime
>  13:01:09 up 260 days, 18:06, 12 users,  load average: 20.53, 20.91, 21.40
> 
> but the message does *not* suggest that the reason it won't let me do-
> release-upgrade is that there is a reboot pending.
> 
> Indeed, even after a reboot and sudo apt-get update; sudo apt-get
> upgrade I get the same message.

If you run 'sudo apt-get dist-upgrade' are there any packages available
for upgrading? Its possible the error message should have said
'dist-upgrade' instead of 'upgrade'.

Thanks!
--
Brian Murray

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1797209

Title:
  do-release-upgrade should block release upgrades in some circumstances

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Xenial:
  Fix Released
Status in ubuntu-release-upgrader source package in Bionic:
  Fix Released
Status in ubuntu-release-upgrader source package in Cosmic:
  Fix Released

Bug description:
  Impact
  ------
  do-release-upgrade will allow people to upgrade to a new release of Ubuntu even if they have outstanding updates to install or need to reboot from a libc6 upgrade. This behavior is different than that of update-manager which forces you to install all updates or reboot before upgrading. Additionally, this specifically allows users to upgrade without receiving fixes that would improve the upgrade process e.g. bug 1780996.

  Test Case for missing updates
  -----------------------------
  1) Install Ubuntu 18.04 and don't install updates.
  2) Modify /etc/update-manager/release-upgrades so Prompt=normal
  3) Run 'do-release-upgrade -d'

  With the current version of ubuntu-release-upgrader-core you'll be
  able to upgrade to Ubuntu 18.10, with the version from -proposed
  you'll receive a message saying "Please install all available updates
  for your release before upgrading."

  Test Case for libc6 update
  --------------------------
  1) Install Ubuntu 18.04
  2) Modify /etc/update-manager/release-upgrades so Prompt=normal
  3) Run 'sudo apt-get install --reinstall libc6'
  4) Run 'do-release-upgrade -d'

  With the current version of ubuntu-release-upgrader-core you'll be
  able to upgrade to Ubuntu 18.10, with the version from -proposed
  you'll receive a message saying "You have not rebooted after a
  previous libc6 update. Please reboot before upgrading."

  Regression Potential
  --------------------
  The strings are not translated but that seems better than people having a bad outcome when upgrading. It's also worth noting that 
  /usr/lib/ubuntu-release-upgrader/release-upgrade-motd calls /usr/lib/ubuntu-release-upgrader/check-new-release to write a stamp file which contains information about the availability of a release upgrade. The behavior of check-new-release should be the same i.e. it should say a new release is available and not mention the need to install updates or reboot. This can be tested by running '/usr/lib/ubuntu-release-upgrader/check-new-release -qcd'. The output should contain "New release ... available ... use do-release-upgrade".

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1797209/+subscriptions