[Bug 1742378] Re: Slight glitch in /etc/cron.daily/apt-compat Ubuntu 16.04.3 in apt-1.2.24

[rklemme]

Produces this output:

$ sh check_power_test.sh 
+ echo begin
begin
+ check_power 0
+ exit 0
+ return 0
+ check_power 1
+ exit 1
+ [ 1 -ne 1 ]
+ return 1
+ echo ignore
ignore
+ check_power 255
+ exit 255
+ [ 255 -ne 1 ]
+ return 0
+ echo end
end


** Attachment added: "Demonstration of behavior of the patch"
   https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1742378/+attachment/5034118/+files/check_power_test.sh

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1742378

Title:
  Slight glitch in /etc/cron.daily/apt-compat Ubuntu 16.04.3 in
  apt-1.2.24

Status in apt package in Ubuntu:
  New

Bug description:
  I accidentally stumbled across this. If in line 22 on_ac_power returns
  a non zero exit code the next line is never reached. Instead, the
  shell terminates immediately with that non zero exit code because of
  "set -e" in line 3. In this script it does not pose a problem because
  the shell is asked to exit anyway if check_power() returns non zero
  but it works differently than is apparently intended (concluding from
  the logic).

  I will attach a suggest patch and a demo illustrating that the patch
  works as the original script seems to intend to.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1742378/+subscriptions