[Bug 1742378] Re: Slight glitch in /etc/cron.daily/apt-compat Ubuntu 16.04.3 in apt-1.2.24

[rklemme]

@Julian I had considered that.  This could be more easily done with
"on_ac_power || return 1" - there is no need for full "if...then...fi".

But both those solutions would have different semantics than what the
script _apparently_ intends to do: on_ac_power returns 0 on AC, 1 on
battery and 255 if the power status cannot be determined.  The current
code of the script indicates that in this case
/usr/lib/apt/apt.systemd.daily should be executed and _only_ be omitted
if on_ac_power returns exactly 1.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1742378

Title:
  Slight glitch in /etc/cron.daily/apt-compat Ubuntu 16.04.3 in
  apt-1.2.24

Status in apt package in Ubuntu:
  Fix Committed

Bug description:
  I accidentally stumbled across this. If in line 22 on_ac_power returns
  a non zero exit code the next line is never reached. Instead, the
  shell terminates immediately with that non zero exit code because of
  "set -e" in line 3. In this script it does not pose a problem because
  the shell is asked to exit anyway if check_power() returns non zero
  but it works differently than is apparently intended (concluding from
  the logic).

  I will attach a suggest patch and a demo illustrating that the patch
  works as the original script seems to intend to.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1742378/+subscriptions