[Bug 1781176] [NEW] Blacklisted packages are included in the "upgradable origin", while they should not

[Balint Reczey]

Public bug reported:

[Impact]

 * Reports from u-u incorrectly list packages from non-upgradable
origins as "Packages with upgradable origin but kept back"

 * The incorrectly the packages incorrectly is a result of
is_pkgname_in_blacklist() having a side effect and removing the side
effect is part of fixing LP: #1396787 which fix is also being SRU-d.

 * The fix is removing the side effect of is_pkgname_in_blacklist()

[Test Case]

 * There is a build-time test in test/test_blacklisted_wrong_origin.py
 * TODO copy test case here from GitHub report 

[Regression Potential]

 * Regressions may make packages incorrectly missing from u-u's report,
but the autopkgtests also cover that to some extent.

[Other Info]
 
 * Original report: https://github.com/mvo5/unattended-upgrades/issues/116

** Affects: unattended-upgrades
     Importance: Unknown
         Status: Unknown

** Affects: unattended-upgrades (Ubuntu)
     Importance: Undecided
         Status: New

** Bug watch added: github.com/mvo5/unattended-upgrades/issues #116
   https://github.com/mvo5/unattended-upgrades/issues/116

** Also affects: unattended-upgrades via
   https://github.com/mvo5/unattended-upgrades/issues/116
   Importance: Unknown
       Status: Unknown

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unattended-upgrades in Ubuntu.
https://bugs.launchpad.net/bugs/1781176

Title:
  Blacklisted packages are included in the "upgradable origin", while
  they should not

Status in unattended-upgrades:
  Unknown
Status in unattended-upgrades package in Ubuntu:
  New

Bug description:
  [Impact]

   * Reports from u-u incorrectly list packages from non-upgradable
  origins as "Packages with upgradable origin but kept back"

   * The incorrectly the packages incorrectly is a result of
  is_pkgname_in_blacklist() having a side effect and removing the side
  effect is part of fixing LP: #1396787 which fix is also being SRU-d.

   * The fix is removing the side effect of is_pkgname_in_blacklist()

  [Test Case]

   * There is a build-time test in test/test_blacklisted_wrong_origin.py
   * TODO copy test case here from GitHub report 

  [Regression Potential]

   * Regressions may make packages incorrectly missing from u-u's
  report, but the autopkgtests also cover that to some extent.

  [Other Info]
   
   * Original report: https://github.com/mvo5/unattended-upgrades/issues/116

To manage notifications about this bug go to:
https://bugs.launchpad.net/unattended-upgrades/+bug/1781176/+subscriptions