[Bug 1753940] Re: go vet causing Crushing failure and despair

[Dimitri John Ledkov]

I am confused about the value of running go vet, in autopkgtests, as any
issues discovered by go vet, during testing of affects of reverse
dependencies on a released version of snapd. This is not as installed
testing, and would require manual changes to the code.

** Changed in: golang-1.10 (Ubuntu)
     Assignee: (unassigned) => Michael Hudson-Doyle (mwhudson)

** Changed in: snapd (Ubuntu)
     Assignee: (unassigned) => Michael Vogt (mvo)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to golang-1.10 in Ubuntu.
https://bugs.launchpad.net/bugs/1753940

Title:
  go vet causing Crushing failure and despair

Status in britney:
  New
Status in golang-1.10 package in Ubuntu:
  New
Status in snapd package in Ubuntu:
  New

Bug description:
  go vet fails on snapd in bionic-release, as follows:

  Running vet
  # github.com/snapcore/snapd/advisor
  advisor/backend.go:178: literal copies lock value from *db: github.com/snapcore/snapd/vendor/github.com/snapcore/bolt.DB contains sync.Pool contains sync.noCopy
  # github.com/snapcore/snapd/cmd/snap_test
  cmd/snap/cmd_snap_op_test.go:825: Fprintln arg list ends with redundant newline
  cmd/snap/interfaces_common_test.go:68: github.com/snapcore/snapd/cmd/snap.AttributePair composite literal uses unkeyed fields
  cmd/snap/interfaces_common_test.go:69: github.com/snapcore/snapd/cmd/snap.AttributePair composite literal uses unkeyed fields
  # github.com/snapcore/snapd/overlord/devicestate_test
  overlord/devicestate/devicestate_test.go:403:38: internal compiler error: no function definition for [0xc4216b8120] FUNC-method(*devicestate.DeviceManager) func() asserts.KeypairManager

  
  Please file a bug report including a short program that triggers the error.
  https://golang.org/issue/new
  # github.com/snapcore/snapd/overlord/ifacestate_test
  overlord/ifacestate/ifacestate_test.go:116:29: internal compiler error: no function definition for [0xc421039da0] FUNC-method(*ifacestate.InterfaceManager) func()

  
  Please file a bug report including a short program that triggers the error.
  https://golang.org/issue/new
  # github.com/snapcore/snapd/snap_test
  snap/info_test.go:471: ExampleSplitSnapAppShort refers to unknown identifier: SplitSnapAppShort

  Crushing failure and despair.

To manage notifications about this bug go to:
https://bugs.launchpad.net/britney/+bug/1753940/+subscriptions