[Bug 1751986] Comment bridged from LTC Bugzilla

[bugproxy]

------- Comment From hegdevasant at in.ibm.com 2018-03-07 04:39 EDT-------
Below three commits should resolve this issue.

commit 45cc84fd958b530aedcc2f9e19f9e11d196d9ee6 (HEAD -> master, origin/next, origin/master, origin/HEAD)
Author: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
Date:   Thu Mar 1 15:58:00 2018 +0530

vpdupdate: Validate file presence before reading data

commit 604132155fd5242411f178b2afdd3b50d841956e
Author: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
Date:   Sat Mar 3 13:27:58 2018 +0530

lsmcode: Add product version string to firmware information

Author: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
Date:   Fri Mar 2 10:39:56 2018 +0530

lsmcode: Fix failure of displaying all device possible micro code

-Vasant

------- Comment From hegdevasant at in.ibm.com 2018-03-07 04:42 EDT-------
Hello Canonical.

I've attached three patches to bugzilla.. Not sure whether patches are
pushed to launchpad properly...

Otherwise can you pull commits mentioned in bugzilla from upstream? It
applies cleanly on top of Ubuntu 18.04 version...Let me know if you need
any clarification.

-Vasant

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to lsvpd in Ubuntu.
https://bugs.launchpad.net/bugs/1751986

Title:
  [LTCTest][OPAL][OP920] lsmcode -A is not showing any output

Status in The Ubuntu-power-systems project:
  Incomplete
Status in lsvpd package in Ubuntu:
  Incomplete

Bug description:
  == Comment: #5 - Pridhiviraj Paidipeddi <ppaidipe at in.ibm.com> - 2018-02-26 11:02:21 ==
  We are missing Product Version in lsmcode output, due to which "lsmcode -A" fails.
  lsmcode(incorrect output)
  =================
  Version of System Firmware : 
   Product Name          : OpenPOWER Firmware
   Product Extra         : 	occ-fce2d94
   Product Extra         : 	skiboot-v5.9-238-g43eb8bbcbaa5
   Product Extra         : 	buildroot-2017.11-5-g65679be
   Product Extra         : 	capp-ucode-p9-dd2-v2
   Product Extra         : 	petitboot-v1.6.6-p91994c3
   Product Extra         : 	sbe-86ae83c
   Product Extra         : 	hostboot-binaries-8b5adb5
   Product Extra         : 	machine-xml-4374657
   Product Extra         : 	hostboot-52ca812
   Product Extra         : 	linux-4.14.13-openpower1-pdb952b4

  lsmcode(correect output)
  ================
  Version of System Firmware : 
   Product Name          : OpenPOWER Firmware
   Product Version       : open-power-SUPERMICRO-P9DSU-V1.03-20180205-imp
   Product Extra         : 	occ-577915f
   Product Extra         : 	skiboot-v5.9-240-g081882690163-pcbedce4
   Product Extra         : 	petitboot-v1.6.6-p019c87e
   Product Extra         : 	sbe-095e608
   Product Extra         : 	machine-xml-fb5f933
   Product Extra         : 	hostboot-9bfb201
   Product Extra         : 	linux-4.14.13-openpower1-p78d7eee

  So we need two fixes here, one is to form Product Version string and
  another one is to fix "lsmcode -A"  empty output bug when there is no
  Product Version available.

  == Comment: #6 - Pridhiviraj Paidipeddi <ppaidipe at in.ibm.com> - 2018-02-26 11:10:23 ==
  Attached patch will fix "lsmcode -A" empty output issue.

  [root at ltc-wspoon2 lsvpd]# ./lsmcode -A
  enP5p1s0f0 !.5719-v1.43 NCSI v1.3.12.0
  enP5p1s0f1 !.5719-v1.43 NCSI v1.3.12.0
  sg0 0:0:0:0 sda !ST1000NX0313.BE35
  sg1 1:0:0:0 sdb !ST1000NX0313.BE35
  [root at ltc-wspoon2 lsvpd]# ./lsmcode -v
  lsmcode 1.7.8
  [root at ltc-wspoon2 lsvpd]# ./lsmcode 
  Version of System Firmware : 
   Product Name          : OpenPOWER Firmware
   Product Extra         : 	occ-fce2d94
   Product Extra         : 	skiboot-v5.9-238-g43eb8bbcbaa5
   Product Extra         : 	buildroot-2017.11-5-g65679be
   Product Extra         : 	capp-ucode-p9-dd2-v2
   Product Extra         : 	petitboot-v1.6.6-p91994c3
   Product Extra         : 	sbe-86ae83c
   Product Extra         : 	hostboot-binaries-8b5adb5
   Product Extra         : 	machine-xml-4374657
   Product Extra         : 	hostboot-52ca812
   Product Extra         : 	linux-4.14.13-openpower1-pdb952b4

  Tested on a AC922 system where the failure occurs when it is having a
  firmware OP920.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1751986/+subscriptions