[Bug 472234] Re: update-manager-core DistUpgrade/utils.py does not honour http_proxy env variable

[Steve Langasek]

Well, apologies for following up on this bug so long after the fact.

I've had a look at the code and the behavior in Ubuntu 16.04 (and later)
and I believe it's correct.

- an apt proxy setting is used if configured.
- otherwise, a synaptic proxy setting is used if configured.
- otherwise, an http_proxy env variable is used if present.
- otherwise, no proxy is used.

We prefer the apt proxy over the generic proxy because it is the one
that has been specifically configured for package management.  We also
use the apt proxy setting in Ubuntu for downloads from update-notifier,
despite the fact that these are non-package downloads.  This is not
without its downsides, since it imposes requirements on the
configuration of the proxy to proxy things other than apt archives, but
it is nevertheless by design.

The only bug I found was in the comment itself, which did not accurately
document the current behavior.  I have pushed a commit to the update-
manager repository which fixes the code comment.

** Changed in: update-manager (Ubuntu)
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-manager in Ubuntu.
https://bugs.launchpad.net/bugs/472234

Title:
  update-manager-core DistUpgrade/utils.py does not honour http_proxy
  env variable

Status in update-manager package in Ubuntu:
  Fix Released

Bug description:
  Binary package hint: update-manager-core

  Distribution Version Information:
  Description:	Ubuntu 9.04
  Release:	9.04

  Package Information:
  ii  update-manager-core    1:0.111.9    manage release upgrades

  Description of Problem:
  The init_proxy method of DistUpgrade/utils.py does not honour defined http_proxy environment variables despite comments in the file saying it should.

  Steps to reproduce:
  1. Setup an ubuntu 9.04 server behind a firewall that blocks outbound connections
  2. Configure a http proxy for the server to connect to
  3. Set the ubuntu server environment variable: export http_proxy="http://proxy.server.name:port"
  4. run do-release-upgrade -s

  Expected result:
  Output related to downloading karmic.tar.gz files

  Actual result:
  Unable to find release to download

  Patch attached:
  I have written a small patch to actually check for the existence of a http_proxy env variable and use it, please find it attached. As a disclaimer I will say that I am generally not a python programmer so apologies in advance

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/472234/+subscriptions