[Bug 1799839] Re: not possible to use "Repair broken packages"

[Łukasz Zemczak]

Hello Brian, or anyone else affected,

Accepted ubuntu-release-upgrader into bionic-proposed. The package will
build now and be available at https://launchpad.net/ubuntu/+source
/ubuntu-release-upgrader/1:18.04.28 in a few hours, and then in the
-proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: ubuntu-release-upgrader (Ubuntu Bionic)
       Status: New => Fix Committed

** Tags added: verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to friendly-recovery in Ubuntu.
https://bugs.launchpad.net/bugs/1799839

Title:
  not possible to use "Repair broken packages"

Status in friendly-recovery package in Ubuntu:
  Triaged
Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in friendly-recovery source package in Bionic:
  New
Status in ubuntu-release-upgrader source package in Bionic:
  Fix Committed
Status in friendly-recovery source package in Cosmic:
  New
Status in ubuntu-release-upgrader source package in Cosmic:
  Fix Committed

Bug description:
  [Impact]
  It is not possible to use "Repair broken packages" in friendly recovery as it calls dist-upgrade.py and that fails as it checks to see if the python symlink, not python3 symlink is good.

  [Test Case]
  Run the following as root:

  env RELEASE_UPGRADER_NO_SCREEN=1 python3 "/usr/lib/python3/dist-
  packages/DistUpgrade/dist-upgrade.py" --partial --frontend
  DistUpgradeViewText --datadir /usr/share/ubuntu-release-upgrader

  With the version in the archive you'll receive an error regarding your
  python install being corrupted, with the version from --proposed you
  won't.

  Also after installing the new version of python3-distupgrade the
  system should be booted into recovery mode and it confirmed that the
  "Repair broken packages" menu item works.

  [Regression Potential]
  The code is just being updated to use python3 instead of python so there isn't any change of a regression.

  The menu item "Repair broken packages" calls the following command:

  env RELEASE_UPGRADER_NO_SCREEN=1 python3 "/usr/lib/python3/dist-
  packages/DistUpgrade/dist-upgrade.py" --partial --frontend
  DistUpgradeViewText --datadir /usr/share/ubuntu-release-upgrader

  However, that fails with the following:

  Your python install is corrupted. Please fix the '/usr/bin/python'
  symlink.

  This is because of the _pythonSymlinkCheck function in
  DistUpgradeController.py (provided by ubuntu-release-upgrader) using
  os.readlink('/usr/bin/python') but not os.readlink() on what the first
  os.readlink() call returned. That being said the whole function should
  be updated to see if python3 is being used.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/friendly-recovery/+bug/1799839/+subscriptions