[Bug 1206215] Re: Accepted pbuilder 0.230 (source) into unstable

[Mattia Rizzolo]

On Fri, Nov 09, 2018 at 09:27:25PM +0000, Thorsten Glaser wrote:
> Mattia Rizzolo dixit:
> >     + Add a --no-source-only-chnages option to override a configured
> 
> chnages? I hope it’s not typo’d in the code.

uops, yes!
luckily I typoed only in the commit message (and hence the changelog),
code and manpages are fine.

changelog fixed locally, thank you!

> >     + Don't explicitly pass -rfakeroot to dpkg-buildpackage.
> >       dpkg-buildpackage uses it by default if present since v1.14.7, so no
> >       need to tell it to.  LP: #1206215
> 
> Please keep passing -rfakeroot for chroots in which etch or older run.
> (Apparently, hardy and lenny have version > 1.14.7 so “should” work.
> If not, you can bet I’m gonna complain :D)

uhhh....
Guess I'll add a check based on the dpkg version, similar to the R-R-R
one.

> Hm, that being said, thanks to #854725 I have to temporarily downgrade
> pbuilder to 0.227 in order to build for these, anyway ☹ (This still
> kinda sucks as I don’t get all the other recent improvements there, like…

Umh, I somehow completely ignored that bug.... sorry!
Guess that one could be also taken care of by a check on dpkg's version,
disabling support for the (willingly undocumented) BUILDSUBDIR option.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pbuilder in Ubuntu.
https://bugs.launchpad.net/bugs/1206215

Title:
  pbuilder forces use of fakeroot

Status in pbuilder package in Ubuntu:
  Fix Committed

Bug description:
  The file /usr/lib/pbuilder/pbuilder-buildpackage parses options and
  builds the command line for debuild. It includes the line:

      DEBBUILDOPTS="${DEBBUILDOPTS:+$DEBBUILDOPTS }-rfakeroot"

  Note that it unequivocally appends "-rfakeroot" to the debuild command
  line. In turn, debuild parses the command line such that the last
  instance of the -r option is used. So even if you set DEBBUILDOPTS to
  have an alternative -r option, it will have no effect.

  This can be worked around by making "-rfakeroot" appear at the
  beginning, so any user-supplied -r option appears last and will take
  effect. But this depends on behavior coded into debuild. A better
  solution would be to check of DEBBUILDOPTS contains a -r or --rootcmd
  option, and only force the inclusion of -rfakeroot if not provided.

  Description:	Ubuntu 12.04.2 LTS
  Release:	12.04

  pbuilder:
    Installed: 0.208ubuntu1
    Candidate: 0.208ubuntu1
    Version table:
   *** 0.208ubuntu1 0
          500 http://us.archive.ubuntu.com/ubuntu/ precise/main amd64 Packages
          100 /var/lib/dpkg/status

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pbuilder/+bug/1206215/+subscriptions