[Bug 1804887] [NEW] software-properties-qt should not run as root

[Carlo Vanini]

Public bug reported:

s-p-qt should not be run as root (with sudo or pkexec), instead it
should use the DBus backend like s-p-gtk does. This way the UI runs as
unprivileged user, and the user is asked for credentials when making
changes.

Motivation:
* Running the UI with sudo is bad.
* It doesn't work in Wayland. (https://bugs.kde.org/show_bug.cgi?id=391965)
* The DBus backend already exists and is used by s-p-gtk.

RFC:
The attached patch changes s-p-qt to use the DBus service for the settings in the first tab (enable/disable components, change server).
Any comment on how it works or should work?

Known issues with the patch:
* When a change fails to be applied the UI doesn't notice and is out of sync with system state. That's because the DBus service never returns a value (except for DBus error). Solution is to reload the config after every change attempt.

** Affects: software-properties (Ubuntu)
     Importance: Undecided
         Status: New

** Patch added: "partial implementation"
   https://bugs.launchpad.net/bugs/1804887/+attachment/5215765/+files/0001-Use-DBus-backend-to-make-changes.patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/1804887

Title:
  software-properties-qt should not run as root

Status in software-properties package in Ubuntu:
  New

Bug description:
  s-p-qt should not be run as root (with sudo or pkexec), instead it
  should use the DBus backend like s-p-gtk does. This way the UI runs as
  unprivileged user, and the user is asked for credentials when making
  changes.

  Motivation:
  * Running the UI with sudo is bad.
  * It doesn't work in Wayland. (https://bugs.kde.org/show_bug.cgi?id=391965)
  * The DBus backend already exists and is used by s-p-gtk.

  RFC:
  The attached patch changes s-p-qt to use the DBus service for the settings in the first tab (enable/disable components, change server).
  Any comment on how it works or should work?

  Known issues with the patch:
  * When a change fails to be applied the UI doesn't notice and is out of sync with system state. That's because the DBus service never returns a value (except for DBus error). Solution is to reload the config after every change attempt.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1804887/+subscriptions